-
Notifications
You must be signed in to change notification settings - Fork 461
CSV Improvements: RVI/MVI and Units #9395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jasondegraw
wants to merge
11
commits into
develop
Choose a base branch
from
csv-rvi-mvi
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
7993c4f
Add NFP for RVI/MVI for CSV
jasondegraw 1c4cdc5
Working RVI/MVI for internal CSV output
mbadams5 808bd9d
Clean up comments and code
mbadams5 0d85f03
Merge remote-tracking branch 'origin/develop' into rvi_mvi_for_csv_ou…
mbadams5 fc32259
Remove commented out information
mbadams5 4d13748
Merge branch 'rvi_mvi_for_csv_output' into csv-rvi-mvi
mbadams5 5584a52
Fix clang format issues
mbadams5 4171287
Merge branch 'develop' into csv-rvi-mvi
jasondegraw 05f47b2
Add ISO 8601 option for CSV and JSON
jasondegraw 692a1ef
Merge branch 'develop' into csv-rvi-mvi
jasondegraw 69ab3bd
Change interface slightly, update unit tests
jasondegraw File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,111 @@ | ||
| # EnergyPlus Output CSV Formatting (RVI/MVI) # | ||
|
|
||
| **Brett Bass, Mark Adams** | ||
|
|
||
| **Oak Ridge National Laboratory** | ||
|
|
||
| - Date: April 7, 2022 | ||
|
|
||
| ## Justification for new feature ## | ||
|
|
||
| --- | ||
| EnergyPlus output CSV format does not currently allow for ordering of reporting or meter variables or specification of variable units. | ||
|
|
||
| ## Overview ## | ||
|
|
||
| --- | ||
|
|
||
| The EnergyPlus native CSV output is a useful new feature but it eliminates the need for “ReadVarsESO”. “ReadVarsESO” previously had the capability to use “.rvi” or “.mvi” file types. The “.rvi” file was used to order and filter the reporting variables while the “.mvi” was used to order and filter meter variables. A need for unit conversions in the native CSV output has also been raised. This was previously possible using the convertESOMTR executable. | ||
| These new features will address these deficiencies in the native CSV output by adding “rvi”, “mvi”, “CSV:Style” objects which can be used to: | ||
|
|
||
| - Filter and order the output reporting (rvi) and meter variables (mvi) | ||
| - Convert output units (CSV:Style) | ||
|
|
||
| ## Approach ## | ||
|
|
||
| --- | ||
|
|
||
| This new feature will be added through and execution of these subtasks: | ||
|
|
||
| 1. Create three new EnergyPlus input objects (rvi, mvi, ouput units) | ||
| 2. Properly read and integrate new EnergyPlus input objects | ||
| 3. Add filtering and sorting mechanism based on rvi and mvi input object | ||
| 4. Add ability to convert units between SI and imperial units to “CSVWriter::parseTSOutputs” based on output unit input object | ||
| 5. Create unit tests to ensure that column order and unit conversions are correct | ||
| 6. Document changes | ||
|
|
||
| ## Testing/Validation/Data Sources ## | ||
|
|
||
| --- | ||
| Additions will be made to the Input Output Reference for the mvi, rvi, and output unit objects. | ||
|
|
||
| ## Input Description ## | ||
|
|
||
| --- | ||
|
|
||
| ``` | ||
| OutputControl:RVI, | ||
| \extensible:1 | ||
| \memo Determine order of CSV output reporting variables | ||
| \unique-object | ||
| A1, \field Key Name 1 | ||
| \begin-extensible | ||
| A2, \field Key Name 2 | ||
| A3, \field Key Name 3 | ||
| A4, \field Key Name 4 | ||
| A5, \field Key Name 5 | ||
| A6, \field Key Name 6 | ||
| A7, \field Key Name 7 | ||
| A8, \field Key Name 8 | ||
| A9, \field Key Name 9 | ||
| A10; \field Key Name 10 | ||
|
|
||
| OutputControl:MVI, | ||
| \extensible:1 | ||
| \memo Determine order of CSV output meter variables | ||
| \unique-object | ||
| A1, \field Key Name 1 | ||
| \begin-extensible | ||
| A2, \field Key Name 2 | ||
| A3, \field Key Name 3 | ||
| A4, \field Key Name 4 | ||
| A5, \field Key Name 5 | ||
| A6, \field Key Name 6 | ||
| A7, \field Key Name 7 | ||
| A8, \field Key Name 8 | ||
| A9, \field Key Name 9 | ||
| A10; \field Key Name 10 | ||
|
|
||
| OutputControl:CSV:Style, | ||
| \memo Unit conversions on reporting and meter variables | ||
| \unique-object | ||
| A1; \field Unit Conversion | ||
| \type choice | ||
| \key None | ||
| \key JtoKWH | ||
| \key JtoMJ | ||
| \key JtoGJ | ||
| \key InchPound | ||
| \default None | ||
| ``` | ||
|
|
||
| ## Outputs Description ## | ||
|
|
||
| --- | ||
| The order of output reporting and meter variables in the CSV output and the units of the CSV output may change based on the rvi, mvi, and output unit input objects. | ||
|
|
||
| ## Engineering Reference ## | ||
|
|
||
| --- | ||
| There will be no change to the Engineering Reference as only column order and units will be changed with this new feature. | ||
|
|
||
| ## Example File and Transition Changes ## | ||
|
|
||
| --- | ||
| Suitable example file will be generated to demonstrate the ability to change output CSV column order and units | ||
|
|
||
| ## References ## | ||
|
|
||
| --- | ||
|
|
||
| NA | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks perfectly reasonable. I was thinking if the csv is not created/requested and these new objects are present in the input then the "unused objects" message will show up in the err file, and if the csv is created/requested those messages will not show up.