Skip to content

Acre unit support (HIP-RA-X reservoir area) [v3.15.3] - #512

Merged
softwareengineerprogrammer merged 5 commits into
NatLabRockies:mainfrom
softwareengineerprogrammer:main
Jul 16, 2026
Merged

Acre unit support (HIP-RA-X reservoir area) [v3.15.3]#512
softwareengineerprogrammer merged 5 commits into
NatLabRockies:mainfrom
softwareengineerprogrammer:main

Conversation

@softwareengineerprogrammer

@softwareengineerprogrammer softwareengineerprogrammer commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator

Description

Support acre units - relevant to HIP-RA-X reservoir area

Testing & Verification

  1. Unit tests added: test_area_acre
  2. Unit tests updated: N/A
  3. Manual testing:
    1. Manually tested
    2. Web interface:
      1. https://gtp.scientificwebservices.com/hip-ra/?hip-ra-parameters=eyJSZXNlcnZvaXIgVGVtcGVyYXR1cmUiOiIyNTAuMCIsIlJlamVjdGlvbiBUZW1wZXJhdHVyZSI6IjYwLjAiLCJSZXNlcnZvaXIgUG9yb3NpdHkiOiIxMC4wIiwiUmVzZXJ2b2lyIEFyZWEiOiIxMDk5MzAgYWNyZSIsIlJlc2Vydm9pciBUaGlja25lc3MiOiIwLjI1IiwiUmVzZXJ2b2lyIExpZmUgQ3ljbGUiOiIyNSJ9

Change Checklist

Observe the following checklist items before and after merging, as applicable.

Before merging:

  1. I certify that I am a human and I have manually verified the correctness of the changes in this PR.
  2. Add a CHANGELOG entry: 8e5e3c4

After merging:

  1. Push tag(s) to GitHub: git push origin refs/tags/v3.15.3: https://github.com/NatLabRockies/GEOPHIRES-X/releases/tag/v3.15.3
  2. Post a change announcement to the GEOPHIRES Change Announcements Discussion: Not warranted

Self-reviewed in softwareengineerprogrammer#176

@softwareengineerprogrammer softwareengineerprogrammer added the bug Something isn't working label Jul 8, 2026
@softwareengineerprogrammer
softwareengineerprogrammer marked this pull request as ready for review July 13, 2026 17:00

@jeffbourdier jeffbourdier left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Short & sweet!

@softwareengineerprogrammer
softwareengineerprogrammer merged commit f873f29 into NatLabRockies:main Jul 16, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants