Skip to content

Include indirect costs in vertical and lateral (non-vertical) section drilling costs [v3.17] - #520

Open
softwareengineerprogrammer wants to merge 16 commits into
NatLabRockies:mainfrom
softwareengineerprogrammer:main
Open

softwareengineerprogrammer wants to merge 16 commits into
NatLabRockies:mainfrom
softwareengineerprogrammer:main

Conversation

@softwareengineerprogrammer

@softwareengineerprogrammer softwareengineerprogrammer commented Sep 10, 2026

Copy link
Copy Markdown
Collaborator

Description

  1. Addresses Drilling and completion costs per well variants do not report indirect costs consistently #519 (relevant to Standardize specific costs #400)
  2. Mention Warn user if ORC is used with production temperature greater than 200 degrees C #517 in v3.17 CHANGELOG entry/announcement
  3. Add py313 to GitHub Actions softwareengineerprogrammer/GEOPHIRES#182

Testing & Verification

  1. Unit tests added: N/A
  2. Unit tests updated:
    1. test_non_vertical_section_cost
    2. Affected examples regenerated
  3. Manual testing:
    1. Manually verified and reviewed:
      1. (6+6) * (3.54+2.24) = 69.36
    2. Web interface: https://gtp.scientificwebservices.com/geophires?geophires-example-id=example_SAM-single-owner-PPA

Change Checklist

Observe the following checklist items before and after merging, as applicable.

Before merging:

  1. I certify that I am a human and I have manually verified the correctness of the changes in this PR.
  2. Add a CHANGELOG entry: softwareengineerprogrammer@bdd4cf6, c450ce8

After merging:

  1. Push tag(s) to GitHub: git push origin refs/tags/v3.17.0
  2. Post a change announcement to the GEOPHIRES Change Announcements Discussion (example). Markdown template:
3.17: [Warn user if ORC is used with production temperature greater than 200 degrees C](https://github.com/NatLabRockies/GEOPHIRES-X/pull/517); [Include indirect costs in vertical and lateral (non-vertical) section drilling costs](https://github.com/NatLabRockies/GEOPHIRES-X/pull/520) | [release](https://github.com/NREL/GEOPHIRES-X/releases/tag/v3.17.0)

Self-reviewed in softwareengineerprogrammer#181

@softwareengineerprogrammer softwareengineerprogrammer added bug Something isn't working documentation Improvements or additions to documentation labels Sep 10, 2026
@softwareengineerprogrammer
softwareengineerprogrammer marked this pull request as ready for review September 10, 2026 18:05
Comment on lines +83 to +88
# - name: 'py314 (ubuntu)'
# python: '3.14'
# toxpython: 'python3.14'
# python_arch: 'x64'
# tox_env: 'py314'
# os: 'ubuntu-latest'

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

py314 fails (https://github.com/softwareengineerprogrammer/GEOPHIRES/actions/runs/34702022162/job/103575354221), so commented it out and left as implicit TODO for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Drilling and completion costs per well variants do not report indirect costs consistently

1 participant