-
Notifications
You must be signed in to change notification settings - Fork 27
Iron: Adding electrowinning capabilities #432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jmartin4u
wants to merge
56
commits into
NatLabRockies:develop
Choose a base branch
from
jmartin4u:ewin-merge
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 19 commits
Commits
Show all changes
56 commits
Select commit
Hold shift + click to select a range
26a6ec6
Reading in Stinn input tables
jmartin4u 3a803fd
Sucessfully testing Stinn model
jmartin4u 6fa32fd
Merge remote-tracking branch 'upstream/develop' into ewin-dev
jmartin4u 9d4ff83
Making humbert perf model
jmartin4u 84aad1c
Adding humbert/stinn cost model inputs only
jmartin4u 674cd47
Progress on humbert cost
jmartin4u 0728b2d
Humbert Stinn complete, not debugged
jmartin4u 9601cce
Debugging electrowinning
jmartin4u 3351d51
Merge remote-tracking branch 'upstream/develop' into ewin-dev
jmartin4u 6310a12
Debugging ewinning
jmartin4u 6455234
Merge remote-tracking branch 'upstream/develop' into ewin-dev
jmartin4u 4f978b8
Electrowinning cases running, need to add DRI case
jmartin4u bd5cdb4
Merge remote-tracking branch 'upstream/develop' into ewin-dev
jmartin4u 9388822
Cleanup of old trailing underscores
jmartin4u db6864b
Fix input csv names
jmartin4u c130111
Merge remote-tracking branch 'upstream/develop' into ewin-merge
jmartin4u 0b41cbf
Integrate ewin example with feedstocks
jmartin4u ab63af7
Moving functions out of h2i module and renumbering example
jmartin4u 47b6535
Merge branch 'develop' into ewin-merge
johnjasa 149ee57
Small fixes to PR
jmartin4u efa47cc
start of unit test
kbrunik 5b44977
Merge branch 'ewin-merge' of https://github.com/jmartin4nrel/H2Integr…
kbrunik 502aa8c
Testing example
jmartin4u 8c79a30
Expanding unit tests
jmartin4u 95c5e70
Merge branch 'develop' into ewin-merge
kbrunik d30a44a
fix import
kbrunik 3992372
Docstrings begun
jmartin4u 6845b13
Docstrings plus a little reorg
jmartin4u 9229ed7
Everything but the docs page
jmartin4u bde4c2d
Finished documentation
jmartin4u d3af390
Split off humbert cost_model
jmartin4u 4e51c3b
Config docstrings
jmartin4u 504785a
Merge remote-tracking branch 'upstream/develop' into ewin-merge
jmartin4u 821ba8b
Merge branch 'develop' into ewin-merge
johnjasa 674dac1
Refactoring iron ewinning calcs for clarity
johnjasa c34f4e5
Addressing reviews
jmartin4u 71ea58a
Merge branch 'develop' into ewin-merge
johnjasa a7e62c7
site -> sites
jmartin4u f4b24f5
Updating test values
jmartin4u c4cc271
Merge remote-tracking branch 'upstream/develop' into ewin-merge
jmartin4u 09fa9a2
Merge branch 'develop' into ewin-merge
johnjasa 98bb8c5
Added autodoc to the electrowinning docs
johnjasa fe7d704
Merge branch 'develop' into ewin-merge
johnjasa 2a0d6d5
Merge remote-tracking branch 'upstream/develop' into ewin-merge
jmartin4u 6464330
Merge branch 'develop' into ewin-merge
johnjasa 85a11a7
Merge branch 'develop' into ewin-merge
kbrunik 39b9ba7
merged in develop
elenya-grant 89b1c5f
updated iron electrowinning tech config
elenya-grant 4b43951
updated plant config for electrowinning example
elenya-grant 71967dc
minor udpates to cost model
elenya-grant f8ef558
minor updates to cost and performance models
elenya-grant 1544cbd
fixed initialization error in cost model
elenya-grant 1c5a82a
removed duplicate costs and updated to use PerformanceModelBaseClass
elenya-grant 9038c6e
updated example test values
elenya-grant 1ea3e07
Merge branch 'develop' into ewin-merge
johnjasa 61dced2
Addressing elenya comments
jmartin4u File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| name: "H2Integrate_config" | ||
|
|
||
| system_summary: "This reference hybrid plant is located in Minnesota and contains wind, solar, and battery storage technologies. The system is designed to produce hydrogen using an electrolyzer and also produce steel using a grid-connected plant." | ||
jmartin4u marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| driver_config: "driver_config.yaml" | ||
| technology_config: "tech_config.yaml" | ||
| plant_config: "plant_config.yaml" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| name: "driver_config" | ||
| description: "This analysis runs a hybrid plant to match the first example in H2Integrate" | ||
jmartin4u marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| general: | ||
| folder_output: outputs | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,76 @@ | ||
| name: "plant_config" | ||
| description: "This plant is located in MN, USA..." | ||
|
|
||
| site: | ||
| latitude: 41.717 | ||
| longitude: -88.398 | ||
|
|
||
| # array of polygons defining boundaries with x/y coords | ||
| boundaries: [ | ||
elenya-grant marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| { | ||
| x: [0.0, 1000.0, 1000.0, 0.0], | ||
| y: [0.0, 0.0, 100.0, 1000.0], | ||
| }, | ||
| { | ||
| x: [2000.0, 2500.0, 2000.0], | ||
| y: [2000.0, 2000.0, 2500.0], | ||
| } | ||
| ] | ||
|
|
||
|
|
||
| # array of arrays containing left-to-right technology | ||
| # interconnections; can support bidirectional connections | ||
| # with the reverse definition. | ||
| # this will naturally grow as we mature the interconnected tech | ||
| technology_interconnections: [ | ||
| # connect feedstocks to iron mine | ||
| ["grid_feedstock","iron_mine","electricity","cable"], | ||
| ["mine_feedstock","iron_mine","crude_ore","pipe"], | ||
| # connect feedstocks to iron plant | ||
| ["iron_mine","iron_plant","iron_ore","iron_transport"], | ||
| ["ewin_grid_feedstock","iron_plant","electricity","cable"], | ||
| ] | ||
|
|
||
| plant: | ||
| plant_life: 30 | ||
| finance_parameters: | ||
| finance_groups: | ||
| finance_model: "ProFastComp" | ||
| model_inputs: | ||
| params: | ||
| analysis_start_year: 2032 | ||
| installation_time: 36 # months | ||
| inflation_rate: 0.0 # 0 for nominal analysis | ||
| discount_rate: 0.09 # nominal return based on 2024 ATB baseline workbook for land-based wind | ||
| debt_equity_ratio: 2.62 # 2024 ATB uses 72.4% debt for land-based wind | ||
| property_tax_and_insurance: 0.03 # percent of CAPEX estimated based on https://www.nrel.gov/docs/fy25osti/91775.pdf https://www.house.mn.gov/hrd/issinfo/clsrates.aspx | ||
| total_income_tax_rate: 0.257 # 0.257 tax rate in 2024 atb baseline workbook, value here is based on federal (21%) and state in MN (9.8) | ||
| capital_gains_tax_rate: 0.15 # H2FAST default | ||
| sales_tax_rate: 0.07375 # total state and local sales tax in St. Louis County https://taxmaps.state.mn.us/salestax/ | ||
| debt_interest_rate: 0.07 # based on 2024 ATB nominal interest rate for land-based wind | ||
| debt_type: "Revolving debt" # can be "Revolving debt" or "One time loan". Revolving debt is H2FAST default and leads to much lower LCOH | ||
| loan_period_if_used: 0 # H2FAST default, not used for revolving debt | ||
| cash_onhand_months: 1 # H2FAST default | ||
| admin_expense: 0.00 # percent of sales H2FAST default | ||
| capital_items: | ||
| depr_type: "MACRS" # can be "MACRS" or "Straight line" | ||
| depr_period: 5 # 5 years - for clean energy facilities as specified by the IRS MACRS schedule https://www.irs.gov/publications/p946#en_US_2020_publink1000107507 | ||
| refurb: [0.] | ||
| cost_adjustment_parameters: | ||
| cost_year_adjustment_inflation: 0.025 | ||
| target_dollar_year: 2022 | ||
| finance_subgroups: | ||
| iron_ore: | ||
| commodity: "iron_ore" | ||
| commodity_stream: "iron_mine" | ||
| technologies: ["iron_mine", "grid_feedstock", "mine_feedstock"] | ||
| sponge_iron: | ||
| commodity: "sponge_iron" | ||
| commodity_stream: "iron_plant" | ||
| technologies: | ||
| - "iron_mine" | ||
| - "grid_feedstock" | ||
| - "mine_feedstock" | ||
| - "iron_transport" | ||
| - "iron_plant" | ||
| - "ewin_grid_feedstock" | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.