Repository navigation
Conversation
EPvalidator checked EER < SEER and EER2 <= SEER2, but a mixed pair (SEER with EER2, or SEER2 with EER) was compared by neither check, so an impossible combination validated. On a variable-speed system the SEER2/EER2 ratio can then fall below the start of the Addendum 82 table, the extrapolated minimum-speed capacity comes out above nominal, and EnergyPlus terminates. Cooling efficiencies must now be SEER2 with EER2, or SEER with EER, for central ACs, mini-split ACs, and air-to-air and mini-split heat pumps. The existing comparisons then cover every input. Closes NatLabRockies#2270 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This was referenced Sep 16, 2026
shorowit
reviewed
Sep 28, 2026
Per review: heat pumps must also pair HSPF with SEER and HSPF2 with SEER2, for air-to-air and mini-split heat pumps. The existing heat pump SEER/EER2 test case now also uses HSPF so it reports only its own error. The workflow_inputs.rst changes are reverted; EER2 <= SEER2 already implies the pairing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
shorowit
approved these changes
Sep 28, 2026
shorowit
left a comment
shorowit
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Will merge when the CI comes back clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2270.
Pull Request Description
EPvalidator checks EER < SEER and EER2 ≤ SEER2, but a mixed pair — SEER with EER2, or SEER2 with EER — is compared by neither, so an impossible combination validates. On a variable-speed system the SEER2/EER2 ratio can then fall below the start of the Addendum 82 table; the extrapolated minimum-speed capacity comes out above nominal and EnergyPlus terminates (
SizeDXCoil: … Speed 1 Rated Air Flow Rate must be less than or equal to Speed 2 …).Cooling efficiencies must now be SEER2 with EER2, or SEER with EER, for central ACs, mini-split ACs, and air-to-air and mini-split heat pumps. With that, the existing comparisons cover every input. Per review, air-to-air and mini-split heat pumps must also pair HSPF with SEER, and HSPF2 with SEER2.
base-hvac-mini-split-heat-pump-ductless.xmlwith SEER 14.0 and EER2 21.27 now fails validation:No sample files are affected — none of the HPXML files in the repo mixes SEER/EER or SEER/HSPF generations, and BuildResidentialHPXML only ever writes one cooling efficiency per system.
The same change for OpenStudio-ERI's 301validator is in NatLabRockies/OpenStudio-ERI#820.
Checklist
Not all may apply:
EPvalidator.sch) has been updatedopenstudio tasks.rb update_hpxmls) — not needed; no sample file mixes generationstest_validation.rb: SEER + EER2 on an air-to-air heat pump, SEER2 + EER on a central AC, SEER + HSPF2 on an air-to-air heat pump, SEER2 + HSPF on a mini-split heat pump. The validation tests pass with OpenStudio 3.11.0openstudio tasks.rb update_measureshas been run — equivalent for this change:openstudio measure -u HPXMLtoOpenStudio(checksums for the changed files), and rubocop reports no offenses in the changed test file🤖 Generated with Claude Code