Skip to content

Fixup autosize hvac #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmarrec merged 3 commits into from
Nov 13, 2025
Merged

Fixup autosize hvac #226

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e1b5848
Fix autosize hvac
jmarrec Nov 13, 2025
fdb0946
Ignore a few things
jmarrec Nov 13, 2025
e3eaf9a
Commit rubocop --auto-correct (Ruby ruby 3.2.2 (2023-03-30 revision e…
Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions model/simulationtests/autosize_hvac.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,8 +391,16 @@ def make_tes_coil(model)
wwhp = OpenStudio::Model::HeatPumpWaterToWaterEquationFitCooling.new(model)
chw_loop.addSupplyBranchForComponent(wwhp)
cw_loop.addDemandBranchForComponent(wwhp)

chw_storage = OpenStudio::Model::ThermalStorageChilledWaterStratified.new(model)
chw_storage.setSetpointTemperatureSchedule(chw_temp_sch)
chw_storage.setTankRecoveryTime(4.0)
chw_storage.waterHeaterSizing.setTimeforTankRecovery(4.0)
chw_storage.autosizeSourceSideDesignFlowRate
chw_storage.autosizeNominalCoolingCapacity
chw_storage.autosizeUseSideDesignFlowRate
chw_storage.autocalculateSourceSideOutletHeight
chw_storage.autocalculateUseSideInletHeight
chw_loop.addSupplyBranchForComponent(chw_storage)
storage_loop.addDemandBranchForComponent(chw_storage)

Expand Down
19 changes: 15 additions & 4 deletions test_helpers.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,15 +176,15 @@ def get_cli_subcommand_from_env(sdk_version_str, debug: false)
$IntersectDir = File.join($RootDir, 'model/intersectiontests/')
$IntersectFile = File.join($RootDir, 'intersect.rb.erb')

if !ENV['TEST_DIR'].nil?
if ENV['TEST_DIR'].nil?
$TestDir = File.join($RootDir, 'testruns')
else
$TestDir = ENV.fetch('TEST_DIR', 'testruns')
# If it's a relative path, make it absolute
if File.expand_path($TestDir) != $TestDir
$TestDir = File.join($RootDir, $TestDir)
end
puts "Setting TestDir to #{$TestDir}"
else
$TestDir = File.join($RootDir, 'testruns')
end

$SddSimDir = File.join($RootDir, 'model/sddtests/')
Expand Down Expand Up @@ -982,7 +982,18 @@ def autosizing_test(filename, weather_file = nil, model_measures = [], energyplu
],
'OS:HeatPump:AirToWater:FuelFired:Heating' => [
'autosizedDesignTemperatureLift' # E+ is missing it
]
],
'OS:EvaporativeFluidCooler:SingleSpeed' => [
'autosizedDesignEnteringWaterTemperature' # E+ is missing it
],
'OS:EvaporativeFluidCooler:TwoSpeed' => [
'autosizedDesignEnteringWaterTemperature' # E+ is missing it
],
# TODO: temp
'OS:HeatPump:AirToWater:Heating' => 'all', # Not in test model
'OS:HeatPump:AirToWater:Cooling' => 'all', # Not in test model
'OS:HeatPump:AirToWater:Heating:SpeedData' => 'all', # Not in test model
'OS:HeatPump:AirToWater:Cooling:SpeedData' => 'all' # Not in test model
}

# Aliases for some OS onjects
Expand Down