-
Notifications
You must be signed in to change notification settings - Fork 222
Support for steam systems #5455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
joseph-robertson
wants to merge
24
commits into
develop
Choose a base branch
from
steam-baseboard-and-pump
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+5,330
−87
Draft
Changes from 16 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
4d3cb34
Initial add of idd objects for steam baseboard and condensate pump.
joseph-robertson de60f97
Stub all zone, coil, and pump model and ft files.
joseph-robertson 6c4d86a
Formatting.
joseph-robertson bbfcfaf
Update all other model files.
joseph-robertson a837e5f
Update coil and pump model files.
joseph-robertson cd8cb4c
Typos.
joseph-robertson 18b192f
Cleanup to idd, model files, and ft.
joseph-robertson 9c7d52f
Update proposed idd design object to follow water.
joseph-robertson c088956
Reference typo in proposed idd.
joseph-robertson b6df791
Wrap PipeAdiabaticSteam and CoilHeatingSteam.
joseph-robertson e9fbc44
Formatting.
joseph-robertson 8e3da6b
Remove PipeAdiabaticSteam wrap.
joseph-robertson 01e794c
Make Skin Loss Radiative Fraction required.
joseph-robertson 9811f64
Add District test files to energplus CMakeLists.
joseph-robertson 563f5e1
Update a bunch of model and ft files and tests.
joseph-robertson 2c99a76
Formatting.
joseph-robertson dc01866
Fix includes in District ft test files.
joseph-robertson 17e322c
Add BoilerSteam ft test file.
joseph-robertson 2410749
Refactor helper methods.
joseph-robertson 797233f
Begin to make updates for support of CoilHeatingSteam.
joseph-robertson ba79552
Move CoilHeatingSteam ft test into its own file.
joseph-robertson fc2f399
Update all applicable model and ft files for CoilHeatingSteam support.
joseph-robertson 86304ea
Updates for ZoneHVACTerminalUnitVRF with supplemental CoilHeatingWate…
joseph-robertson 2197a10
Merge branch 'develop' into steam-baseboard-and-pump
joseph-robertson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -94,6 +94,7 @@ set(${target_name}_src | |
| ForwardTranslator/ForwardTranslateCoilHeatingGas.cpp | ||
| ForwardTranslator/ForwardTranslateCoilHeatingGasMultiStage.cpp | ||
| ForwardTranslator/ForwardTranslateCoilHeatingWater.cpp | ||
| ForwardTranslator/ForwardTranslateCoilHeatingSteam.cpp | ||
| ForwardTranslator/ForwardTranslateCoilHeatingWaterToAirHeatPumpEquationFit.cpp | ||
| ForwardTranslator/ForwardTranslateCoilHeatingWaterToAirHeatPumpVariableSpeedEquationFit.cpp | ||
| ForwardTranslator/ForwardTranslateCoilPerformanceDXCooling.cpp | ||
|
|
@@ -302,6 +303,7 @@ set(${target_name}_src | |
| ForwardTranslator/ForwardTranslatePortList.cpp | ||
| ForwardTranslator/ForwardTranslatePumpConstantSpeed.cpp | ||
| ForwardTranslator/ForwardTranslatePumpVariableSpeed.cpp | ||
| ForwardTranslator/ForwardTranslatePumpVariableSpeedCondensate.cpp | ||
| ForwardTranslator/ForwardTranslatePythonPluginInstance.cpp | ||
| ForwardTranslator/ForwardTranslatePythonPluginVariable.cpp | ||
| ForwardTranslator/ForwardTranslatePythonPluginTrendVariable.cpp | ||
|
|
@@ -444,6 +446,7 @@ set(${target_name}_src | |
| ForwardTranslator/ForwardTranslateZoneHVACBaseboardConvectiveWater.cpp | ||
| ForwardTranslator/ForwardTranslateZoneHVACBaseboardRadiantConvectiveElectric.cpp | ||
| ForwardTranslator/ForwardTranslateZoneHVACBaseboardRadiantConvectiveWater.cpp | ||
| ForwardTranslator/ForwardTranslateZoneHVACBaseboardRadiantConvectiveSteam.cpp | ||
| ForwardTranslator/ForwardTranslateZoneHVACCoolingPanelRadiantConvectiveWater.cpp | ||
| ForwardTranslator/ForwardTranslateZoneHVACDehumidifierDX.cpp | ||
| ForwardTranslator/ForwardTranslateZoneHVACEnergyRecoveryVentilator.cpp | ||
|
|
@@ -744,6 +747,9 @@ set(${target_name}_test_src | |
| Test/DaylightingDeviceLightWell_GTest.cpp | ||
| Test/DesignDay_GTest.cpp | ||
| Test/DesignSpecificationOutdoorAir_GTest.cpp | ||
| Test/DistrictCooling_GTest.cpp | ||
| Test/DistrictHeatingWater_GTest.cpp | ||
| Test/DistrictHeatingSteam_GTest.cpp | ||
|
Comment on lines
+752
to
+754
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yikes - DistrictCooling and DistrictHeatingWater FT tests weren't being run... |
||
| Test/ElectricEquipment_GTest.cpp | ||
| Test/ElectricEquipmentITEAirCooled_GTest.cpp | ||
| Test/ElectricLoadCenterDistribution_GTest.cpp | ||
|
|
@@ -857,6 +863,7 @@ set(${target_name}_test_src | |
| Test/WaterUseConnections_GTest.cpp | ||
| Test/ZoneAirHeatBalanceAlgorithm_GTest.cpp | ||
| Test/ZoneHVACBaseboardRadiantConvectiveWater_GTest.cpp | ||
| Test/ZoneHVACBaseboardRadiantConvectiveSteam_GTest.cpp | ||
| Test/ZoneHVACEvaporativeCoolerUnit_GTest.cpp | ||
| Test/ZoneHVACLowTemperatureRadiantElectric_GTest.cpp | ||
| Test/ZoneHVACLowTempRadiantConstFlow_GTest.cpp | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.