Skip to content

Slow gr si ox nmc811#27

Merged
c-randall merged 9 commits intomainfrom
slowGrSiOxNMC811
Apr 20, 2026
Merged

Slow gr si ox nmc811#27
c-randall merged 9 commits intomainfrom
slowGrSiOxNMC811

Conversation

@malihass
Copy link
Copy Markdown
Collaborator

@malihass malihass commented Apr 16, 2026

Description

Ability to include a slow version of the GrSiOx-NMC811 where the OCV are not exposed in BATMODS-lite.
Also did some small spelling cleanup and variable naming cleanup.

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that improves speed/readability/etc.)
  • Bug fix (non-breaking change which fixes an issue)
  • Chore (any other clean up, maintenance, etc.)

Key checklist:

  • No style issues: $ nox -s linter [-- format]
  • Code is free of misspellings: $ nox -s codespell [-- write]
  • All tests pass: $ nox -s tests

Further checks:

  • The documentation builds: $ nox -s docs.
  • Code is commented, particularly in hard-to-understand areas.
  • Tests are added that prove fix is effective or that feature works.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 16, 2026

Codecov Report

❌ Patch coverage is 86.66667% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.45%. Comparing base (0845d96) to head (058d479).

Files with missing lines Patch % Lines
src/bmlite/materials/_graphite_SiOx.py 87.50% 3 Missing ⚠️
src/bmlite/materials/_nmc_811.py 87.50% 3 Missing ⚠️
src/bmlite/P2D/domains.py 80.00% 1 Missing ⚠️
src/bmlite/SPM/domains.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #27      +/-   ##
==========================================
- Coverage   91.59%   91.45%   -0.15%     
==========================================
  Files          31       31              
  Lines        2178     2234      +56     
==========================================
+ Hits         1995     2043      +48     
- Misses        183      191       +8     
Flag Coverage Δ
unittests 91.45% <86.66%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@malihass malihass requested a review from c-randall April 16, 2026 19:09
@c-randall c-randall merged commit ff5dfd9 into main Apr 20, 2026
21 checks passed
@c-randall c-randall deleted the slowGrSiOxNMC811 branch April 20, 2026 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants