Add turbine_average_velocities property to UncertainFlorisModel#1135
Merged
misi9170 merged 9 commits intoNatLabRockies:developfrom Aug 18, 2025
Merged
Conversation
Collaborator
Author
|
The failing tests seem unrelated to this PR but I could be mistaken |
Collaborator
Collaborator
Author
Collaborator
|
Thanks @paulf81 , this looks good to me. I've added a few things:
As we discussed, I've also:
I think this looks good. However, there are still a lot of methods on |
misi9170
approved these changes
Aug 11, 2025
turbine_average_velocities property to UncertainFlorisModel
Collaborator
|
@paulf81 , any objections/comments on the changes I made? If not, I think I can merge. |
Collaborator
Author
Yes, these look great, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add turbine average velocity property to UncertainFLorisModel
This PR adds a property to allow getting the per-turbine average velocities from an UncertainFlorisModel. This property exists for FlorisModel. To provide this capability in UncertainFLorisModel requires mirroring the logic in get_turbine_powers to go from the expanded internal FlorisModel (which includes all the unique conditions after expanding across neighboring wind directions according to the wd_std) back to the un_expanded originally requested wind directions.
Several tests are included to check the functino works as expected
Impacted areas of the software
uncertain_floris_model.py
Test results, if applicable
New tests pass