Skip to content

Refactor/reconcile plotters#48

Open
scottmello37 wants to merge 3 commits intomainfrom
refactor/reconcile_plotters
Open

Refactor/reconcile plotters#48
scottmello37 wants to merge 3 commits intomainfrom
refactor/reconcile_plotters

Conversation

@scottmello37
Copy link
Collaborator

Reconciled 2D and 3D plotting modules. No functionality was changed, only placing the functions in the new file geopfa/plotters.py, leaving the old modules with transition imports and warnings, and updating the example notebooks to import with import geopa.plotters.

@ntaverna, feel free to glance at it. Should be straight forward.

…, leaving only transition imports and warnings. No changes were made to plotting functionality.
@scottmello37 scottmello37 requested a review from ntaverna February 6, 2026 19:32
@scottmello37 scottmello37 self-assigned this Feb 6, 2026
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 0% with 284 lines in your changes missing coverage. Please review.
✅ Project coverage is 23.14%. Comparing base (24302ea) to head (7be3cce).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
geopfa/plotters.py 0.00% 272 Missing ⚠️
geopfa/geopfa2d/plotters.py 0.00% 6 Missing ⚠️
geopfa/geopfa3d/plotters.py 0.00% 6 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #48      +/-   ##
==========================================
+ Coverage   15.58%   23.14%   +7.56%     
==========================================
  Files          18       19       +1     
  Lines        2804     2743      -61     
  Branches      434      425       -9     
==========================================
+ Hits          437      635     +198     
+ Misses       2340     2065     -275     
- Partials       27       43      +16     
Flag Coverage Δ
unittests 23.14% <0.00%> (+7.56%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@ntaverna ntaverna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, as long as notebooks run and you are able to merge (looks like your branch is behind main)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants