Skip to content

Updated example yaml files to work with latest Hercules version, plus minor bug fixes#93

Merged
misi9170 merged 13 commits intoNatLabRockies:developfrom
jfrederik-nrel:bugfixes_examples
Feb 20, 2026
Merged

Updated example yaml files to work with latest Hercules version, plus minor bug fixes#93
misi9170 merged 13 commits intoNatLabRockies:developfrom
jfrederik-nrel:bugfixes_examples

Conversation

@jfrederik-nrel
Copy link
Contributor

  • Updated the yaml input files to work with the latest version of Hercules, replacing the no longer existing component_type Wind_MesoToPowerPrecomFloris.
  • Cleaned up examples/simple_hybrid_plant/plant_power_reference.csv to remove redundant entries.
  • Changed unit in the label on x-axis of the single_turbine_flexible_interconnect example to mins instead of s.
  • Improved theramp_rate_limit implementation in WindFarmPowerTrackingController. This still needs more attention though, tagging @misi9170 for that.

@misi9170 misi9170 added bug Something isn't working examples Changes to examples labels Feb 16, 2026
@misi9170
Copy link
Collaborator

Thanks @jfrederik-nrel !

I've added a few things to this PR:

  • Fixed the ramp rate limitations in the wind farm power tracking controllers---thanks for identifying the problem there! I reorganized the code a bit there so that the ramp rate limit could be applied in both the PowerTracking and Distributing versions of the controller. I still need to add tests though.
  • Added the noisy_wind_input.csv file needed to run the single_turbine_flexible_interconnect example
  • Reverted the x-axis label you mentioned, since I think seconds is the correct unit (even if it's not necessarily realistic); however, I think this was in the wind_farm_power_tracking example rather than the single_turbine_flexible_interconnect example

I'll work on the tests, and then we should be good to merge this if you're happy with the changes I've made.

@misi9170
Copy link
Collaborator

Test now added, and documentation slightly updated to reflect ramp_rate_limit option in the wind_farm_power_tracking example.

@misi9170 misi9170 self-requested a review February 17, 2026 22:29
@jfrederik-nrel
Copy link
Contributor Author

@misi9170 I have reviewed the changes, and have no further comments. I think this pull request can be merged now.

Copy link
Collaborator

@misi9170 misi9170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @jfrederik-nrel ! Merging now.

@misi9170 misi9170 merged commit f865d5e into NatLabRockies:develop Feb 20, 2026
5 checks passed
@jfrederik-nrel jfrederik-nrel deleted the bugfixes_examples branch February 20, 2026 19:23
@misi9170 misi9170 mentioned this pull request Feb 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working examples Changes to examples

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants