Latest OS-HPXML, v1.11.0#1530
Draft
joseph-robertson wants to merge 85 commits intodevelopfrom
Draft
Conversation
…898924b33 6934898924b33 More progress [ci skip] 4b35aee67831c Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into os311 573a64ede3205 Merge pull request #2092 from NREL/gshp_sizing_error 19c1c9ddb2165 Minor cleanup. [ci skip] a451b1832a5eb Merge branch 'gshp_sizing_error' of https://github.com/NREL/OpenStudio-HPXML into gshp_sizing_error 107de13bd8ec5 Update test. 3ed31906dba47 Latest results. c44d74678e045 Convert var to snake_case c98cf463e5536 Fixes possible ground-source heat pump sizing error if the heating or cooling design temperature differences are zero. 8724df25d2c85 Merge pull request #2086 from NREL/hpwh_adjustment_confined_space f14b342567b92 Minor improvement to schematron f4424e21dfce2 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into hpwh_adjustment_confined_space 34535d1f3d069 Merge pull request #2091 from NREL/panel-outputs fcca4eb0026d1 Revert zone load adjustment. f63523cb42ce3 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into hpwh_adjustment_confined_space f5d6b8311fdc2 Move method for returning number of occupied spaces to hpxml class. a70261a4a20c0 Temporary workaround fd149fd54576f Merge branch 'master' into panel-outputs 3d0a1971eebfa Skip warnings for now 2f4da2f51f896 Latest results. efd0a40755a42 bugfix 6e92e95718a4b add regression for load fractions 4d816c79e9e6d Merge branch 'hpwh_adjustment_confined_space' of https://github.com/NREL/OpenStudio-HPXML into hpwh_adjustment_confined_space fd7ca987b0855 address comments dd9610eb7a06f Temporarily ignore this warning. e56582f109d81 Update tests after headroom and total changes. 67eb965475e60 Move headroom and total from Outputs to main schema. c86ed444ddc72 Minor updates to docs/schematron. 3c018f4e205f8 Merge branch 'hpwh_adjustment_confined_space' of https://github.com/NREL/OpenStudio-HPXML into hpwh_adjustment_confined_space 247539f341bf9 address comments, rename inputs, docs, etc. a7c4e39d0963d Revert this part too [ci skip] de0cce16c03c5 Not worth it, reverting some things [ci skip] 66efbcea46cbf Another fix 115700d0f01dc Fix yaml 1684ccc791a56 Bump OS version & ubuntu version. 5141bcd2f2a2c Latest results. 7a6951602a788 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into hpwh_adjustment_confined_space 9e0a49dae5940 not to adjust capacities; docs, changelog, warnings. 798709532be5d Latest results. f545ae21b1d33 Add boolean inputs, error-checking, unit tests, etc. 2bcb652b680ab Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into hpwh_adjustment_confined_space 31f529e5f8573 Latest results. 85712a6d9ff44 first cut adding adjustment git-subtree-dir: resources/hpxml-measures git-subtree-split: 6934898924b335063700646660ed923e4d777960
… header but the wrong number of Extreme fields.
…7ea349a63 75947ea349a63 Merge pull request #1983 from NREL/mains_temps d6792c31a3d44 Merge branch 'mains_temps' of https://github.com/NREL/OpenStudio-HPXML into mains_temps 002d1d9675137 Update tests. (Unrelated: Remove unused battery lifetime code.) 1742cf62e44d3 Latest results. 0d5fc7c57b9bc Merge branch 'os311' of https://github.com/NREL/OpenStudio-HPXML into mains_temps 1dec9e5ffa71c No longer need this code 5f7f6592695d9 Merge pull request #2094 from NREL/os311_fixmes 6bb52779ff241 Latest results. 02099e80f375e Update comment 1aac02b96d9ba Merge branch 'os311' of https://github.com/NREL/OpenStudio-HPXML into mains_temps 1324a35451f1b update xmls 6774fdf5c9007 Merge branch 'os311' of https://github.com/NREL/OpenStudio-HPXML into os311_fixmes 54d47281a9383 Latest results. bfbc364491f09 Update tests b9bba0362c3b3 Shouldn't need this exception anymore. 31fe289b72a49 Try new docker container on CI 144790b7269c3 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into os311 167022895880f Relax tol a bit [ci skip] c702f0001bf91 Revert FIXMEs due to OpenStudio 3.11 updates [ci skip] 862c702fe00dc Merge pull request #2093 from NREL/change_zerh_to_denh 4a5249019fa5c Revert Changelog.md [ci skip] bd1b5b0991771 Update changelog c0dd9e29efa97 run update_measures 4b90e8b2eb385 Rename ZERHCalculation to DENHCalculation in HPXML class 85e4a966a4947 First pass on using the E+ built-in correlation for mains temperature. Will need NatLabRockies/EnergyPlus#11037 for DWHR systems. git-subtree-dir: resources/hpxml-measures git-subtree-split: 75947ea349a63b60dfafc8f9bdfb03a8e57d6a70
joseph-robertson
changed the base branch from
develop
to
refactor-applyupgrade-posthpxml
…9406f48bb 30559406f48bb A little cleanup 43b8c29434c26 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into os311 a2093af4d788f Latest results. d96c61f257de5 Update HPXML cf5c3f81eca59 Fix CI? 59c86567274eb Merge pull request #2099 from NREL/option_cleanup 6c8ae2b4e02a0 Merge branch 'option_cleanup' of https://github.com/NREL/OpenStudio-HPXML into os311 93968a868a05f Remove InfiltrationVolume too. f713af64e72b9 Rename options for consistency [ci skip] d1b4d4f9e0f0a Latest results. 83c62db530454 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into option_cleanup 18eb1c40b13b8 Apply same logic from walls to rim joists. 3a5ba89943109 A few tweaks. 973b96204b5d0 Better description of the source of the humidity capacity multiplier. 5959dd85034f6 Latest results. 4d9bdbb8a8a85 Add carpet to MF unit sample files. 8b864c1e7fb8a Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into option_cleanup 0690c06d3a996 Merge pull request #2102 from NREL/unit_test_validation f1c6d62e56667 Merge pull request #2101 from NREL/panel-spaces-fix f3458b64de186 Minor updates to docs [ci skip] b3602cd239f38 Set rated total spaces as a defaulted value [ci skip] f20e3ae2b9e5a Update another panel test after pulling in defaulted HPXML validation. d02e92cef4ca0 Update panel tests after pulling in defaulted HPXML validation. 6ffaefb412c4d Merge branch 'unit_test_validation' into panel-spaces-fix b01fabd9f2a31 Revert this change. 2201a0f5b3c21 Fix test_defaults.rb a25a7ba32b163 Latest results. 579bd6c86d478 Remove Breaker Spaces note altogether. [ci skip] 05fecf9748bc2 Validate the `in.xml` files created during unit tests. 624d2e7e2379f Update workflow outputs docs. ebcb5061c9c08 Update panel and validation tests. dc94dcaa955b5 Check that HeadroomSpaces is not negative. f82ee871ac2bd Found some more things to clean up. 439c765f571c9 Update measure 2f96a75948a9e Merge branch 'option_cleanup' of https://github.com/NREL/OpenStudio-HPXML into option_cleanup d299a143b4713 Some more cleanup. 5a4d287d28882 Latest results. 864ef82f38002 Add carpet input to BuildResidentialHPXML measure. bb4449976fcce Update a couple tests; revert roof color change in base.xml. a39cabc6ec49b A bit more cleanup. d7cfe76a00302 Cleanup 728a74da9f4be Some more option updates. Simplify sample files further. Remove a bunch of unnecessary logic in BuildResidentialHPXML measure. 2252833d711ad Rename some of the options for clarity. e9ae6e3bde87e Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into os311 9c5d4247e1f2c Merge pull request #2098 from NREL/materials_rb 06a4f7d403b8a Add Pearl [ci skip] be15e3533f925 Latest results. d14d1553f7bb4 Relax tol slightly 8314e076b0d92 Latest results. 10a8f1432137b Update some more names for clarity. Update outside coefficient. c6782527f4321 Rename inside/outside to interior/exterior. 53fea54c197ea Bugfix. 791a1b817af72 Document materials and some code refactor. git-subtree-dir: resources/hpxml-measures git-subtree-split: 30559406f48bb9c7bfe37dae8e4606bf59f55316
…390ec1e05 3a43390ec1e05 Exclude HVAC installation quality files from unmet hours check. a37e0bff97199 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into os311 6cf928367fd7a Update sha db4fca236b226 Merge pull request #2131 from NREL/hp_17f_error_checking 3071e78b54003 Throw an error if HeatingCapacity17F is provided but HeatingCapacity is not. aa7f14320687e Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into os311 acd443c2d7900 Add R-3 wall insulation per user request. git-subtree-dir: resources/hpxml-measures git-subtree-split: 3a43390ec1e05dd36c8b2dfca028892b0e12aad2
…494c85bf9 37fc494c85bf9 Merge pull request #2089 from NREL/os311 4622ed776c6e0 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into os311 8e9cf5d341615 Remove temp code [ci skip] a635029d3b8b5 Merge pull request #2136 from NREL/hers_sizing_bugfix 2230eb677c487 Merge pull request #2117 from NREL/hpwh_exhaust_ducting aafd0a6dd37aa Latest results. 36d0568ad0592 Merge branch 'hers_sizing_bugfix' of https://github.com/NREL/OpenStudio-HPXML into hers_sizing_bugfix 4b0861fa76a2d Add test. 02484fcda9ef3 Update new HPXML 2b35084446bf1 Merge branch 'os311' of https://github.com/NREL/OpenStudio-HPXML into hpwh_exhaust_ducting 6841c15d3b0f2 Latest results. 405e7deb0288b Exclude fan heat too. fe64f8fcf12cb Merge pull request #2135 from NREL/osw_suppress_log_messages 0b2ccb078332f Latest results. 5556a2642fecb Got it backwards [ci skip] 20bf7e5f82a76 Fixes HERS sizing methodology when compressor lockout temperature is below heating design temperature. c2f1a60fdf37b Add new output to changelog [ci skip] eb102d826d4bd Suppress log messages when running e.g. template-build-hpxml.osw. f61c8f0959fc1 Latest results. 3f699811323aa Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into os311 545e2e05def8a Update HPXML 2337062fc7406 Update to 2026 [ci skip] 1791d0f1ee0b9 Widen tolerance for peak loads. a17e6116f4e59 Use NatLabRockies/OpenStudio#5551 to address hardcoded outlet node name. [ci skip] e85f5a91a678c Merge branch 'os311' of https://github.com/NREL/OpenStudio-HPXML into hpwh_exhaust_ducting 8b56d84451cb9 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into hpwh_exhaust_ducting bf94d169584df Address ducted water heaters in unconditioned space. c50317759908a Latest results. 682698213603a Only adjust infiltration when HPWH is in conditioned space. Update airflow rate to 200 cfm, a better average value. b05ddaea2f92e Latest results. 5dab3700cc26c Temporarily skip 10x test for new sample file 63fdeb3598b72 Add tests for warnings and minor cleanup. ec1af6a3db03e First pass on allowing HPWH exhaust air to be ducted to the outside. git-subtree-dir: resources/hpxml-measures git-subtree-split: 37fc494c85bf92a1b93f79876574a8346f95e73c
bfcf02289e Merge pull request #2143 from NREL/duct_lto_error_msg d8264838e1 Merge branch 'duct_lto_error_msg' of https://github.com/NREL/OpenStudio-HPXML into duct_lto_error_msg 8a85cf4ac3 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into duct_lto_error_msg 6ae6d4e9f6 Latest results. f946cb50f0 Adds error-checking for when the sum of supply/return duct leakage to outside values is too high. 24df99f169 Merge pull request #2141 from NREL/attic_ctf_workaround 7f512cecbb Latest results. e531c0f036 Update Changelog.md [ci skip] ee62e4c9f0 Revert to previous thickness to accommodate lower roof assembly R-values. 2e41b098f3 Prevent thin rigid insulation layers too. 8d25b313c1 Fix combined cp calculation. See if we no longer get an attic warning from E+. 76fe55a38e A little cleanup. 61859b1fa0 Combines the roof material and OSB layers into a single layer for the roof to help avoid attic temperature out of bounds errors. Also moves construction-related code from geometry.rb to constructions.rb. 058d86511b Add software user, clean up IRA reference [ci skip] 168dbb2cf7 Merge pull request #2132 from NREL/update_utility_rates c3dee04abe Latest results. e3d863c801 Update a couple links [ci skip] 24686ab11a Merge pull request #2139 from NREL/os311-rc3 2315b67cbd Merge branch 'update_utility_rates' of github.com:NREL/OpenStudio-HPXML into update_utility_rates a5a8dbc1f9 update inputs doc f5963b964f Merge branch 'master' of github.com:NREL/OpenStudio-HPXML into update_utility_rates 8853cd9438 Fix sha eb6958764d Bump to rc3 bc52124be6 Latest results. b579d96694 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into update_utility_rates c65bb6cb8d Latest results. 3d63df50b8 Merge branch 'master' of github.com:NREL/OpenStudio-HPXML into update_utility_rates 3710e2b347 Merge branch 'update_utility_rates' of github.com:NREL/OpenStudio-HPXML into update_utility_rates 73f89ea507 Update docs 170ec39821 exclude 2024 electricity rates 02a7a1cca1 Latest results. 061093dacd Update test_utility_bills c18dfa28bf run update_measures 2fd4aac715 Update changelog a6bcc13ecf Add 2023 util rates and 2024 elec rates git-subtree-dir: resources/hpxml-measures git-subtree-split: bfcf02289ee24e42ffd84c524fd14f30423ee57a
d64c6c94ea Merge pull request #2145 from NREL/os311final fdd95b20d3 Update to final build 650d319e03 Merge pull request #2144 from NREL/pan_heater_controls 9883ce133a Latest results. cec3f319d5 Minor cleanup [ci skip] a4d2e0c5c9 Adds PanHeaterControlType choice of "heat pump mode", in which the pan heater will run whenever the HP is running (and the outdoor temperature is below 32F). Updates PanHeaterControlType choice of "continuous" to avoid pan heater operation when the outdoor temperature is below the minimum compressor temperature. git-subtree-dir: resources/hpxml-measures git-subtree-split: d64c6c94ea5698eda7570b38457a2212323279dd
|
Hello Joe and Scott, thanks for all the work you’re putting into integrating the latest OpenStudio-HPXML. This looks like a huge effort. I was wondering if you have an estimated timeline for when this pull request might be ready to merge? I also tried the latest-os-hpxml branch locally and ran into a number of errors with whole building simulation enabled as discussed here. I'm new to this kind of collaborated work on GitHub, but please let me know if there is anything I can help to test. I'll be happy to contribute. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Keep ResStock up-to-date w/the master branch of OpenStudio-HPXML.
Related Pull Requests
Pulls in:
Note that because of changes in this PR, to retrieve "breaker space constraint" for a given upgrade, we will now need to diffreport_simulation_output.electric_panel_breaker_spaces_total_countfor the existing and upgraded building (instead of looking at justreport_simulation_output.electric_panel_breaker_spaces_headroom_countfor the upgraded building).in.xmlfiles during unit tests OpenStudio-HPXML#2102enclosure_carpetnot added to lookup; the default (80% Carpet) matches what ResStock was previously using.output.rbOpenStudio-HPXML#2106HeatingCapacity17Ferror checking OpenStudio-HPXML#2131Checked means that something in resstock was changed or updated as a result of pulling in.
Related Pull Requests
[related PRs from different repositories]
Related Issues
[What issue(s) is the PR addressing]
Checklist
Required:
Optional (not all items may apply):
openstudio tasks.rb update_measureshas been run