Prototype whole SFA/MF building + shared system#1546
Draft
joseph-robertson wants to merge 94 commits intolatest-os-hpxmlfrom
Draft
Prototype whole SFA/MF building + shared system#1546joseph-robertson wants to merge 94 commits intolatest-os-hpxmlfrom
joseph-robertson wants to merge 94 commits intolatest-os-hpxmlfrom
Conversation
Adds export of metadata_and_annual_results by various geographies, in both CSV and parquet format.
Rename columns to match ComStock and timeseries file conventions, including: two dots to separate units, standardize unit abbreviations, categorize more outputs as out.param, change the naming of savings columns.
Standardized column names, adds savings columns to baseline, adds weighted energy and savings columns.
Adds upgrade columns from across superset of all upgrades, controls which columns are exported, and adds more descriptive logging to each function.
Moves each action to a function and defines one workflow with slight modifications for baseline and upgrade dataframes. Modifies column definitions to remove unused emissions scenarios and add control of publication location.
Dropping empty energy consumption columns on a per-upgrade basis results in errors for fuel-switching upgrades. Also, set applicability for all buildings.
Adds energy consumption and energy savings intensity (per sqft) columns for use in SightGlass
Edits up through line 115
Edits up through line 241
Update data_dictionary.tsv
…entsPostHPXML is called once.
…et all tests to pass.
…utputs using SimulationOutput.
Comment on lines
+1498
to
+1499
| # runner.registerError("#{fuel_type} category end uses (#{sum_categories.round(3)}) do not sum to total (#{meter_fuel_total.round(3)}).") | ||
| # return false |
Contributor
Author
There was a problem hiding this comment.
Since we are using AddSharedSystem to add object(s) that are not accounted for in ReportSimulationOutput, we essentially need to move the check of end uses sum vs. fuel use to SimulationOutput. This is because the facility meters (e.g., Electricity:Facility) will account for the new object but the end use variables/meters will not.
If we don't want to make the ReportSimulationOutput check (and other checks?) optional, then this IMO is a strong motivation to move AddSharedSystem into OpenStudio-HPXML.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
[description here]
Related Pull Requests
[related PRs from different repositories]
Related Issues
[What issue(s) is the PR addressing]
Checklist
Required:
Optional (not all items may apply):
openstudio tasks.rb update_measureshas been run