Patch clean up old nrel traces-287 - #296
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates WindWatts UI and API text/config to remove remaining nrel.gov references in user-facing links and API documentation contact info, aligning with issue #287’s cleanup goal.
Changes:
- Updated multiple UI external links (turbine metadata references, footer quick links/social links, and result-pane disclaimer) from
nrel.govtonlr.gov. - Updated API description contact email from
windwatts@nrel.govtowindwatts@nlr.gov. - Updated the model configuration “Wind Toolkit” link to the
nlr.govdomain.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| windwatts-ui/src/constants/turbines.ts | Updates turbine reference links to the nlr.gov domain. |
| windwatts-ui/src/constants/footer.ts | Updates footer quick links and social media URLs to new destinations. |
| windwatts-ui/src/components/resultPane/Disclaimer.tsx | Updates WRDB link in the disclaimer to wrdb.nlr.gov. |
| windwatts-api/app/main.py | Updates API docs contact email to windwatts@nlr.gov. |
| windwatts-api/app/config/model_config.py | Updates Wind Toolkit reference link to www.nlr.gov. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
20
to
23
| - Rate limits: tiered - 10 / 100 / 1000 requests per minute per IP. | ||
| - Base path: `/api` | ||
| - Contact: windwatts@nrel.gov | ||
| - Contact: windwatts@nlr.gov | ||
|
|
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.
Suppressed comments (1)
windwatts-api/app/main.py:22
- PR description/issue #287 indicates cleaning up remaining nrel.gov traces, but the repo still contains
raw.github.nrel.govreferences inwindwatts-ui/Dockerfileandwindwatts-ui/Dockerfile.dev(used to fetch certs). If the goal is to fully eliminate nrel.gov domains, these should be updated or explicitly documented as an intentional exception.
- Contact: windwatts@nlr.gov
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
close #287
Checklist
developmake formatandmake verifydevelopfeat/...,fix/...,docs/...,chore/...)feat: add new feature,fix: resolve bug,docs: update documentation)