fix: AWS Source Key - #298
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Windwatts API’s Athena source configuration keys to the new long-form model keys (e.g., era5-quantiles) and adjusts environment-variable parsing to map AWS-friendly underscore naming to hyphenated model keys used by the application.
Changes:
- Restructured the sample Athena config to use a per-source
sourcesmap keyed by the new model keys. - Updated env var parsing so
SOURCES_<SOURCE>_*source identifiers convert_to-(e.g.,ERA5_QUANTILES→era5-quantiles).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| windwatts-api/app/config/sample_windwatts_data_config.json | Updates sample config to the new sources map keyed by long-form model keys. |
| windwatts-api/app/config_manager.py | Adjusts env var parsing to translate underscore source identifiers into hyphenated model keys. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…match with for break
RLiNREL
commented
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
related to #285
The source key update from short era5, wtk, and ensemble were updated to the longer key era5-quantiles, etc. AWS key uses underscore, so a replacement with - hyphen was applied along update to sample config.
AthenaDataFetcher(athena_config, source_key="era5") --> AthenaDataFetcher(athena_config, model_key="era5-quantiles")
Checklist
developmake formatandmake verifydevelopfeat/...,fix/...,docs/...,chore/...)feat: add new feature,fix: resolve bug,docs: update documentation)