[FINNA-2235] Quria: Add support for multiple emails/phone numbers #3022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EreMaijala
requested changes
Sep 25, 2024
EreMaijala
requested changes
Oct 9, 2024
…ctivation checkboxes to form
|
Noniin, pienen veivaamisen jälkeen päädyttiin seuraavaan ratkaisuun:
|
EreMaijala
requested changes
Dec 11, 2024
EreMaijala
requested changes
Dec 20, 2024
local/languages/finna/en-gb.ini
Outdated
| @@ -882,6 +883,7 @@ Performers = "Performers" | |||
| Performing Ensembles = "Performing Ensembles" | |||
| Personal details maintained by the library = "Personal details maintained by the library" | |||
| Phone = "Phone" | |||
| phone_active = "Use for SMS" | |||
There was a problem hiding this comment.
Voisiko käännös vastata paremmin merkitystä tyyliin phone_use_for_sms?
| * | ||
| * @throws ILSException | ||
| * | ||
| * @return array Associative array of the results | ||
| */ | ||
| public function updateEmail($patron, $email) | ||
| public function updateEmail($patron, $email, $emailId = null, $active = false) |
There was a problem hiding this comment.
Pitäisikö tämän olla nyt protected? Ja ehkä vähän eri nimellä (updateEmailAddress?), ettei sekoitu tuohon vanhaan julkiseen metodiin?
There was a problem hiding this comment.
Sama tietty updatePhone:n kohdalla (protected function updatePhoneNumber?)
| @@ -181,6 +181,15 @@ | |||
| <div class="my-profile-col profile-title"><?=$this->transEsc('Phone') ?>:</div> | |||
| <div class="profile-text-value"><?=$this->escapeHtml($this->profile['phone']) ?></div> | |||
| <?php endif; ?> | |||
| <?php elseif (!empty($this->profile['phone_0'])): ?> | |||
There was a problem hiding this comment.
Voisiko tätä ja email_0:aa vielä välttää mappaamalla phone_0:n myös phone-kenttään ja email_0:n myös email-kenttään? Tai oikeastaan ensimmäisen aktiivisen arvon, se kai voi olla muukin kuin indeksillä 0?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.