Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle the case of empty unassigned list for Aviti #889

Merged
merged 2 commits into from
Oct 28, 2024
Merged

Handle the case of empty unassigned list for Aviti #889

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
357a635
Handle case of empty lsit of unassigned items
alneberg Oct 28, 2024
38a5e6c
Merge remote-tracking branch 'upstream/master' into element_empty_bugfix
alneberg Oct 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions run_dir/static/js/element_flowcell.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -586,7 +586,6 @@ app.component('v-element-lane-stats', {
<v-lane-stats-row :sample="unassigned_lane_stats_combined[laneKey]" :laneKey="laneKey"></v-lane-stats-row>
</tbody>
</table>

<div>
<button class="btn btn-info my-2" type="button" data-toggle="collapse" :data-target="'#collapseUndeterminedLane'+ laneKey" aria-expanded="false" :aria-controls="'#collapseUndeterminedLane'+ laneKey">
Show undetermined
Expand All @@ -610,12 +609,12 @@ app.component('v-element-lane-stats', {
</tr>
</thead>
<tbody>
<tr v-for="unassigned_item in this.unassigned_lane_stats[laneKey].slice(0,items_to_show(laneKey))" :key="index">
<tr v-for="unassigned_item in this.$root.getValue(this.unassigned_lane_stats, laneKey, []).slice(0,items_to_show(laneKey))" :key="index">
<td style="font-size: 1.35rem;"><samp>{{ this.$root.barcode(unassigned_item)}}</samp></td>
<td>{{ this.$root.formatNumberFloat( this.$root.getValue(unassigned_item, "% Unassigned"), decimalPoints=5)}} </td>
<td>{{ unassigned_item["Count"] }}</td>
</tr>
<tr v-if="this.unassigned_lane_stats[laneKey].length > items_to_show(laneKey)">
<tr v-if="this.$root.getValue(this.unassigned_lane_stats, laneKey, []).length > items_to_show(laneKey)">
<td colspan="3">
<button class="btn btn-info" @click="show_more_items(laneKey)">Show 5 more...</button>
</td>
Expand Down
Loading