-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add defaulting of non-"false" QueryOption fields to "true" #2420
base: integration
Are you sure you want to change the base?
Conversation
- Create function evaluateBooleanOption() method in QueryOptions - Use evaluateBooleanOption() in the validateOptions() method - Add a test in QueryOptionsTest to test evaluateBooleanOption() resolves #2410
warehouse/query-core/src/main/java/datawave/query/iterator/QueryOptions.java
Outdated
Show resolved
Hide resolved
warehouse/query-core/src/main/java/datawave/query/iterator/QueryOptions.java
Outdated
Show resolved
Hide resolved
…ryOptions.java Co-authored-by: Laura Schanno <[email protected]>
…ryOptions.java Co-authored-by: foster33 <[email protected]>
* @return True if the option is null or not "false". False if the option has the value "false" (not case-sensitive). | ||
*/ | ||
private static boolean evaluateBooleanOption(String value) { | ||
if (value == null) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, this is great. Now we need to add the second part of the ticket which is to update the DefaultQueryPlanner which is setting up these options to use null values instead of "true" when setting up these options on the iterator.
@@ -20,6 +20,7 @@ | |||
import java.util.List; | |||
import java.util.Map; | |||
import java.util.Map.Entry; | |||
import java.util.Objects; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unused import
resolves #2410