Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2416 - maven build cache fix #2422

Open
wants to merge 4 commits into
base: integration
Choose a base branch
from

Conversation

cogross
Copy link
Collaborator

@cogross cogross commented Jun 18, 2024

Changes to allow for the build to work with the maven build cache enabled.

  • mapreduce query microservice pom changed to copy resources earlier
  • quickstart docker changes (disable build cache, for now)

Copy link
Collaborator

@jwomeara jwomeara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think at a minimum we're going to want to disable the build cache for the assemble-datawave and assemble-webservice modules as well. I have run into issues with those failing to rebuild on subsequent build attempts.

@jwomeara
Copy link
Collaborator

Also, as part of your testing can you try building and then rebuilding the full docker compose build, making the following changes independently between builds:

  • modify something in ShardQueryLogic.java
  • modify something in QueryLogicFactory.xml

I just want to make sure that as we make changes to things and rebuild, that the caching doesn't prevent us from building the full suite of artifacts since that's the kind of behavior that we've been seeing.

@cogross
Copy link
Collaborator Author

cogross commented Jun 24, 2024

I think at a minimum we're going to want to disable the build cache for the assemble-datawave and assemble-webservice modules as well. I have run into issues with those failing to rebuild on subsequent build attempts.

Sure -- makes sense. Easy enough to add.

@cogross cogross force-pushed the 2416-maven-build-cache-fix branch 2 times, most recently from d55b2d6 to f260e46 Compare June 25, 2024 15:41
@cogross
Copy link
Collaborator Author

cogross commented Jun 25, 2024

Also, as part of your testing can you try building and then rebuilding the full docker compose build, making the following changes independently between builds:

  • modify something in ShardQueryLogic.java
  • modify something in QueryLogicFactory.xml

I just want to make sure that as we make changes to things and rebuild, that the caching doesn't prevent us from building the full suite of artifacts since that's the kind of behavior that we've been seeing.

It worked for ShardQueryLogic.java.
I made a change to the maven config to let xml (not poms) and yml file changes be taken into account for the maven build cache. Once I did that, a change to the xml file you gave would cause its module (spring-boot-starter-datawave-query) to be rebuilt.

Changes are pushed up, if you wanted to give it another look over.

@cogross cogross requested a review from jwomeara June 27, 2024 12:04
@cogross cogross force-pushed the 2416-maven-build-cache-fix branch from f260e46 to 1b37056 Compare July 2, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants