-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2416 - maven build cache fix #2422
base: integration
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think at a minimum we're going to want to disable the build cache for the assemble-datawave and assemble-webservice modules as well. I have run into issues with those failing to rebuild on subsequent build attempts.
Also, as part of your testing can you try building and then rebuilding the full docker compose build, making the following changes independently between builds:
I just want to make sure that as we make changes to things and rebuild, that the caching doesn't prevent us from building the full suite of artifacts since that's the kind of behavior that we've been seeing. |
Sure -- makes sense. Easy enough to add. |
d55b2d6
to
f260e46
Compare
It worked for ShardQueryLogic.java. Changes are pushed up, if you wanted to give it another look over. |
f260e46
to
1b37056
Compare
Changes to allow for the build to work with the maven build cache enabled.