Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Badge and Adding Microservice build and test to gitlab action #2424

Merged
merged 7 commits into from
Aug 21, 2024
Merged

Adding Badge and Adding Microservice build and test to gitlab action #2424

merged 7 commits into from
Aug 21, 2024

Conversation

doublejai
Copy link
Collaborator

No description provided.

jwomeara
jwomeara requested changes Jun 20, 2024
View reviewed changes
.github/workflows/tests.yml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
properties/dev.properties Outdated Show resolved Hide resolved
@jwomeara
Copy link
Collaborator

I unintentionally lead you astray... Instead of running the microservice build and test, i wanted to run the docker compose tests. here's the entry for that. you should be able to just swap this for the one you added. sorry about that.

datawave/.github/workflows/tests.yml

Line 158 in eb62d64

compose-build-and-test:

@jwomeara
Copy link
Collaborator

One thing that might not work if one of the jobs is failing (even though the overall status is successful) is the ability to merge a PR. I think all of the jobs have to be passing to merge a PR. I created a PR against your PR which should fail the microservice build and let us know one way or the other.

#2426

@doublejai doublejai marked this pull request as ready for review June 27, 2024 10:18
@doublejai doublejai requested a review from jwomeara June 27, 2024 10:23
@jwomeara
Copy link
Collaborator

It looks like your changes might have gotten lost from tests.yml. I don't see any new test configurations added. Just some indentation changes, and comment removal.

@doublejai doublejai closed this Jul 31, 2024
@doublejai doublejai reopened this Jul 31, 2024
jwomeara
jwomeara requested changes Aug 21, 2024
View reviewed changes
Copy link
Collaborator

@jwomeara jwomeara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small request, and then I think this is good to go.

.github/workflows/tests.yml Show resolved Hide resolved
@jwomeara jwomeara merged commit 7b70b47 into integration Aug 21, 2024
5 checks passed
@jwomeara jwomeara deleted the task/GITHUB-2414 branch August 21, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwomeara jwomeara jwomeara approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@doublejai @jwomeara