Extract all fields from filter:includeRegex and filter:excludeRegex … #2450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen an index-only field is present Correct RegexFunctionVisitor incorrectly calling index-only fields non-event fields Correctly apply De Morgans law with ANDed exclusions
apmoriarty
reviewed
Jun 28, 2024
warehouse/query-core/src/test/java/datawave/query/CompositeFunctionsTest.java
Outdated
Show resolved
Hide resolved
apmoriarty
reviewed
Jun 28, 2024
warehouse/query-core/src/test/java/datawave/query/jexl/visitors/RegexFunctionVisitorTest.java
Show resolved
Hide resolved
apmoriarty
approved these changes
Jul 2, 2024
ivakegg
approved these changes
Jul 2, 2024
hgklohr
added a commit
that referenced
this pull request
Jul 3, 2024
…#2450) * Extract all fields from filter:includeRegex and filter:excludeRegex when an index-only field is present Correct RegexFunctionVisitor incorrectly calling index-only fields non-event fields Correctly apply De Morgans law with ANDed exclusions * comments --------- Co-authored-by: hlgp <[email protected]> Co-authored-by: hgklohr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…when an index-only field is present
Correct RegexFunctionVisitor incorrectly calling index-only fields non-event fields
Correctly apply De Morgan's law with ANDed exclusions