NCTO-23 client server system for multiplayer#14
Merged
alexis-belmonte merged 109 commits intomainfrom Mar 13, 2026
Merged
Conversation
…tisfy TypeScript
…client-server-system-for-multiplayer
….g. creating/joining a project during collaboration, hosting/joining a game, etc.
…ng in on the front
alexis-belmonte
changed the title
Contributor
Author
|
Blocks #17 |
alexis-belmonte
requested review from
Notgoyome,
Priax,
TheodoreBillotte and
emaurel
Louis-rollet
requested changes
Mar 8, 2026
src/routes/s3/bucket.service.ts
Outdated
| @Inject(ConfigService) private readonly configService: ConfigService | ||
| ) { | ||
| this.defaultBucket = this.configService.get<string>("S3_BUCKET_NAME"); | ||
| this.defaultBucket = this.configService.get<string>("AWS_DEFAULT_BUCKET"); |
Collaborator
There was a problem hiding this comment.
it's not aws anymore and use the backend .env on our discord or update it
Louis-rollet
reviewed
Mar 8, 2026
… S3 controller and tests
…onment variable handling and improve error handling
…e and remove BucketService
Notgoyome
approved these changes
Mar 12, 2026
| type: UserListResponseDto | ||
| }) | ||
| @ApiResponse({ status: HttpStatus.UNAUTHORIZED, description: "Unauthorized" }) | ||
| @ApiQuery({ type: UserFilterDto }) |
Collaborator
There was a problem hiding this comment.
ooh it was the issue nice 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira ticket
https://naucto.atlassian.net/browse/NCTO-23?atlOrigin=eyJpIjoiMWQ1MWVjZDI2M2ZlNGNkNWE0NzlhYWY4ZTlmZmNmZmQiLCJwIjoiaiJ9
What does your MR do?
@hey-api/openapi-ts.Overview
openHost,closeHost,leaveHost,joinHost, andlookupHostswith proper game session attach/detach logic, DTOs, multiplayer-specific exceptions, and missing Swagger annotations.AppConfiginjectable, and relocated the signaling module to a cleaner path.tool/),generate:swagger/generate:clientnpm scripts, and a GitHub Actions CI pipeline. Migrated fromopenapi-typescript-codegento@hey-api/openapi-ts— eliminating the old post-generation patch script..dockerignore, and added a cleanup script.LFendings globally, added@webrtcpath alias, switched fromtsxtots-node, re-introducedpgdriver, upgraded package set, integrated severalmainmerges.@Injectusage, an auth regression blocking frontend login, and duplicate member generation.How to test it
Test as usual against the frontend, it should work just fine.
Screenshot
Not applicable.
Notes
Still WIP. The collaborative service/controller hasn't been updated yet to use the new WebRTC config structure — likely a follow-up PR.