Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LUA Support #52

Closed
wants to merge 5 commits into from
Closed

LUA Support #52

wants to merge 5 commits into from

Conversation

Adrikikicp
Copy link

Making LUA Support. Based off here: [(https://developer.valvesoftware.com/wiki/Adding_Lua)]

@Nbc66
Copy link
Owner

Nbc66 commented Dec 4, 2023

has this been tested?

@Nbc66
Copy link
Owner

Nbc66 commented Dec 4, 2023

also what's up with the action scrip there we already have action scripts setup to compile for 2013ce its not needed

@PatchByte
Copy link
Contributor

I like that you tried to write a lua implementation. I thank you for trying to contribute to source-sdk-2013-ce.
I don't think that this code fits the source-sdk-2013-ce. The VDC post is existing because lua is not a core component of the source sdk, lua can be a really cool addition to the source sdk, but right now there is no need for it to be directly implemented into the source sdk. This should remain as an additional feature "opt-in", and not something by default.
A lot of users are trying to use vscript and also other scripting languages.
I also commented on your coding style / coding choices, I also think that the coding style does not fit the source engine.
I don't think this should be in the source-sdk-2013-ce right now.
I am sorry, but that is my opinion.

@Nbc66 Nbc66 closed this Dec 5, 2023
@Adrikikicp
Copy link
Author

Thanks for your review! I instead of using another languages use LUA because is more confortable. But yeah, that will be an experimental branch. I was trying to test it, but is not finished so I will add that as TO-DO. Instead I will work in the 64-bit support for making the engine better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants