feat: Improve Pausable Migration Guide and Add Migration Tests#163
Merged
feat: Improve Pausable Migration Guide and Add Migration Tests#163
Conversation
kiseln
reviewed
Mar 8, 2025
kiseln
approved these changes
Apr 4, 2025
Contributor
kiseln
left a comment
There was a problem hiding this comment.
Feeling dejavu like I already reviewed this
frolvanya
approved these changes
Apr 4, 2025
mitinarseny
approved these changes
Apr 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Enhances migration documentation and adds tests for migrating from single
manager_rolesto separatepause_roles/unpause_rolesin the Pausable plugin.Changes
Updated Migration Guide:
#[derive(AccessControlRole)]Added Migration Tests:
Testing
pausable_old,pausable_new)pausable_migration.rstest that: