PR to track downstream changes in a fork#12
PR to track downstream changes in a fork#12AndrewDryga wants to merge 34 commits intoNebo15:masterfrom
Conversation
| [ | ||
| line_length: 110, | ||
| inputs: ["mix.exs", "{config,lib,test}/**/*.{ex,exs}"] | ||
| ] No newline at end of file |
There was a problem hiding this comment.
There should be a final \n at the end of each file.
update deps
delete and log function
| value | ||
| end} | ||
| end) | ||
| |> Map.new() |
There was a problem hiding this comment.
Pipe chain should start with a raw value.
| # this case is entered when the operation type it's a delete operation | ||
| {_, regreso} = | ||
| Map.from_struct(schema) | ||
| |> Map.pop(:__meta__) |
There was a problem hiding this comment.
Pipe chain should start with a raw value.
| Map.from_struct(schema) | ||
| |> Map.pop(:__meta__) | ||
|
|
||
| IO.inspect(regreso) |
There was a problem hiding this comment.
There should be no calls to IO.inspect/1.
| value | ||
| end} | ||
| end) | ||
| |> Map.new() |
There was a problem hiding this comment.
Pipe chain should start with a raw value.
|
Hello @AndrewDryga, at Valiot we are actively maintaining and adding features to ecto_trail as we are using it in our core product. If you like we can take over it. You can take a look at our fork here: https://github.com/valiot/ecto_trail/ We've also been thinking in renaming it so we can publish updated versions to hex.pm What do you think? |
|
Hi @acrogenesis . |
|
I think it would be nice if we collaborate on improving it instead of maintaining two separate versions. I'm even totally okay to give you write access and rights to publish on Hex, if we agree to not introduce breaking changes (because it's used in our production too). |
|
Ebert has finished reviewing this Pull Request and has found:
But beware that this branch is 1 commit behind the You can see more details about this review at https://ebertapp.io/github/Nebo15/ecto_trail/pulls/12. |
Maintenance & custom REDACTED fields
…ngesets change data structure for delete changesets
* update deps * add log\4 for handling log only operations * change log * add log_bulk for log a list changes for a list of created structs * fix struct references in log_bulk * change args naming * add log_bulk test for log only behaviour
Problem: - the original package from Nebo15 (https://github.com/Nebo15/ecto_trail) seems barely supported - the PR to merge the fork from Valiot is stuck in limbo (Nebo15/ecto_trail#12) - the improvements from Valiot are not releases on Hex (and there are some API differences from the original package) Solution: - lets change the name and release an actively maintained package - ecto_trailer is available and seems OK for an alternative implementation
Problem: - the original package from Nebo15 (https://github.com/Nebo15/ecto_trail) seems barely supported - the PR to merge the fork from Valiot is stuck in limbo (Nebo15/ecto_trail#12) - the improvements from Valiot are not releases on Hex (and there are some API differences from the original package) Solution: - lets change the name and release an actively maintained package - ecto_trailer is available and seems OK for an alternative implementation
8 participants
No description provided.