feat(aggregator): add stable integration test pipeline and fix test/runtime config#44
Open
Oluwaseyi89 wants to merge 1 commit intoNeko-Protocol:mainfrom
Open
Conversation
…untime config - simplify integration suite to use implemented services only - fix timestamp type mismatches (string vs number) in test inputs - map normalized records to aggregation input shape before aggregate calls - align edge-case expectations with current service behavior - clean up jest integration config and remove invalid tsconfig.spec reference - fix Nest DI/runtime issue by removing direct strategy providers from AppModule - verify with passing check-types and integration tests
|
@Oluwaseyi89 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Author
|
@Villarley please, review. |
1 similar comment
Author
|
@Villarley please, review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Neko Pull Request
Mark with an
xall the checkboxes that apply (like[x])📌 Type of Change
📝 Changes description
Implements a comprehensive integration test suite for the aggregator pipeline, validating the complete flow from normalization to aggregation with realistic test data.
Core Implementation
Test Configuration (
apps/aggregator/jest.integration.config.js):--runInBandfor sequential executionIntegration Tests (
apps/aggregator/test/integration/aggregation-pipeline.integration.spec.ts):Key Fixes
tsconfig.specreference from jest configAppModuleTest Results
How to Run
📁 Files Added
apps/aggregator/jest.integration.config.jsapps/aggregator/test/integration/aggregation-pipeline.integration.spec.ts📸 Evidence (A Loom/Cap video is required as evidence, we WON'T merge if there's no proof)
https://www.loom.com/share/2e30b0bfd7e947b0a509446362ad3466
⏰ Time spent breakdown
🌌 Comments
--runInBandfor reliabilityCloses #23