Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Dashboard in kiosk mode in read only mode #275

Closed
mizarmess opened this issue Sep 20, 2024 · 6 comments · Fixed by #276
Closed

[BUG] Dashboard in kiosk mode in read only mode #275

mizarmess opened this issue Sep 20, 2024 · 6 comments · Fixed by #276
Labels
🐛 bug Something isn't working

Comments

@mizarmess
Copy link

Describe the bug
When setting up kiosk mode on a dashboard and using on Android 13 (I'm personally using Samsung S20 FE) you cannot click on any button. It seems is in some kind of read only mode.

To Reproduce
Steps to reproduce the behavior:

  1. Add code to dashboard:

kiosk_mode:
mobile_settings:
kiosk: true
hide_header: true
hide_sidebar: true
hide_menu_button: true
hide_overflow: true

  1. Run the HA Companion App and navigate to the dashboard
  2. Dashboard in read only mode

Expected behavior
You should be able to click on buttons and use the dashboard as in normal mode

Versions:

  • Home Assistant: 2024.9.2
  • Kiosk-Mode: v6.1.1
@mizarmess mizarmess added the 🐛 bug Something isn't working label Sep 20, 2024
@elchininet
Copy link
Collaborator

Hi @mizarmess,
I cannot reproduce your issue, I am able to click on my dashboard using your configuration, so I suspect that your issue is coming from somwhere else.
Please, set Chrome Remote Debugging in your Android device and check what is blocking your dashboard and also check for errors in the browser console.
Regards

@elchininet
Copy link
Collaborator

Hi @mizarmess,

I was able to reproduce the issue in a new dashboard (for some reason it is not reproducible in my already created dashboards). Just using this configuration:

kiosk_mode:
  kiosk: true

Let the debugging part on my side. I'll check what is happening there.

@elchininet
Copy link
Collaborator

@mizarmess,
I don't know since when this has been ocurring but basically, there are new elements, classes and animations in the elements related to the sidebar that makes everything break.

I was not able to detect it because it only occurs when one navigates through the sidebar to a dashboard with hide_sidebar (or kiosk) activated, so one needs to have the sidebar activated in one dashboard and deactivated in other. It doesn't occur either if the panel that is loaded has the sidebar hidden.

In the moment that a navigation to a dashboard without sidebar occurs, the animation that closes the sidebar doesn't finish and then multiple classes and attributes are not removed.

I'll work on a fix for this and I'll let you know when it is solved.

Regards

@mizarmess
Copy link
Author

mizarmess commented Sep 21, 2024

Thnx for the prompt looking into the issue and I'm glad you have managed to reproduce it and have some ideas where the problem is. Looking forward for the fix.

Regards :)

@elchininet
Copy link
Collaborator

Hi @mizarmess,
When this pull request gets merged and a new version of the addon is released, your issue will be solved.

This issue was introduced by this change, basically, the body scroll is removed and the interaction with the screen is removed until the sidebar closes (and hiding the sidebar impedes that the logic to remove all those blockers run).

Regards

@NemesisRE
Copy link
Owner

I am currently on vacation without connection to my dev environment, will be back on wednesday to release a new version sorry for the delay 🥺

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants