Fix hide_sidebar option in Companion App #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elchininet
force-pushed
the
fix_hide_sidebar_companion_app
branch
from
bf1c08a
to
b70b687
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When one opens and closes the sidebar, there is a logic behind to manage the Navigation Drawer and its focus trap.
If one hides the sidebar and applies all the styling override that
kiosk-modesapplies, the logic to remove all the inert blockers from the screen and to set all the elements in a closed state is never executed. This is not a problem for those that sethide_sidebarglobally in all the dashboards, but it is a problem if someone wants a dashboard without sidebar and navigates to it from a dashboard with it enabled, because in that moment the logic to close the sidebar is executed and as the sidebar never closes this provokes that it is impossible to interact with the interface.In this pull request a small fix has been introduced. Before hiding the sidebar, we are checking if the
typeof themc-drawerelement ismodal(it occurs in mobile) and if itsappContenthas theinertproperty set intrue(in those cases it is impossible to interact with the screen). If that is the case, then we wait for the MDCDrawer:closed event of the Navigation Drawer, and only after it is fired, we apply the styles to hide the sidebar. In the rest of the cases we hide the sidebar directly without waiting for this event.Closes #275