feat: allow more types for jacobi_symbol (#1855)

Nemocas · Sep 19, 2024 · 59d6a4f · 59d6a4f · lgoettgens · Sep 19, 2024
1 parent 4d25cd4
commit 59d6a4f
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 2 deletions.
diff --git a/Project.toml b/Project.toml
@@ -1,6 +1,6 @@
 name = "Nemo"
 uuid = "2edaba10-b0f1-5616-af89-8c11ac63239a"
-version = "0.47.0"
+version = "0.47.1"
 
 [deps]
 AbstractAlgebra = "c3fe647b-3220-5bb0-a1ea-a7954cac585d"

diff --git a/src/flint/fmpz.jl b/src/flint/fmpz.jl
@@ -2044,6 +2044,8 @@ function jacobi_symbol(x::ZZRingElem, y::ZZRingElem)
                    (Ref{ZZRingElem}, Ref{ZZRingElem}), x, y))
 end
 
+jacobi_symbol(x::IntegerUnion, y::IntegerUnion) = jacobi_symbol(ZZ(x), ZZ(y))
+
 @doc raw"""
     jacobi_symbol(x::Int, y::Int)
 

diff --git a/test/flint/fmpz-test.jl b/test/flint/fmpz-test.jl
@@ -1221,11 +1221,17 @@ end
 
   @test jacobi_symbol(2, 3) == -1
 
+  for T in (Int, Integer, ZZRingElem)
+    for S in (Int, Integer, ZZRingElem)
+      @test jacobi_symbol(T(2), S(3)) == -1
+    end
+  end
+
   @test_throws DomainError jacobi_symbol(2, 0)
 
   @test_throws DomainError jacobi_symbol(-5, 4)
 
-  for T in [Int, ZZRingElem]
+  for T in (Int, ZZRingElem)
     for iters = 1:1000
       m1 = T(rand(-100:100))
       n1 = T(rand(-100:100))