Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make files executable by default #76

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Arthurmeade12
Copy link

This pull request makes files meant to be executed (install_requirements *) executable by default. In addition, it sets the shebang for pluget.py to #!/usr/bin/env python to allow pluget.py to be executed directly, e.g. ./pluget.py.

Thanks for any suggestions.

Copy link
Owner

@Neocky Neocky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What did you change in these both files?

  • install_requirements_LINUX.sh
  • install_requirements_WINDOWS.bat
    Github shows me this as empty change...

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What did you change here?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing unix permissions: 644 -> 755

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What did you change here?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing unix permissions: 644 -> 755

@Neocky Neocky added the Enhancement New feature or request label Feb 20, 2024
@Neocky
Copy link
Owner

Neocky commented Feb 20, 2024

Hey @Arthurmeade12,

thank you so much for your PR.
I will add your PR after you respond to the review. :)
Have a good day! 👋

@Arthurmeade12
Copy link
Author

Thanks @Neocky.
I changed the file permissions on both install_requirements_WINDOWS.bat and install_requirements_LINUX.sh from 644 to 755.
This means that the owner, the group, and everyone will be able to execute this file.
See https://chmod-calculator.com/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants