Skip to content

Commit

Permalink
Merge branch 'cypressImplementation2' into DevBranch
Browse files Browse the repository at this point in the history
  • Loading branch information
Nerajno committed Jun 26, 2023
2 parents 5560094 + 3ad96a2 commit 1d546eb
Show file tree
Hide file tree
Showing 26 changed files with 5,090 additions and 24,301 deletions.
21 changes: 11 additions & 10 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,13 @@ A React-Based Movie Search webapp.

## Description
Responsive Movie app using React, the TMDB api and Sass. It was used to
retool or get a better understanding of React, themovieDb api for movie info and search
functionalities and Sass for styling and Cypress for testing.
retool or get a better understanding of React, themovieDb api for movie info and search
functionalities and Sass for styling and Cypress for testing.

Original Reference material - https://youtu.be/ntYXj9W1Ez8

Changes to be included :
- Fix branding to a unique branding ( icon included).
- Fix branding to a unique branding ( icon included).
- Link to Github repo in the footer.
- Sticky navbar.
- filtered Results (it displays results as you type).
Expand Down Expand Up @@ -39,26 +39,27 @@ Uses:
- [x] Create a sticky navbar.
- [x] Integrate Cypress testing.
- [ ] Create 7 handwritten tests ([See Mark's notes](https://docs.google.com/document/d/1RLlRwHr90q-HfWjUWsA4Y5yxi5X8cYqiJZ8sYVy3yZE/edit?usp=sharing)) && this => https://tinyurl.com/yeyt7fum
- [ ] Create a code style// implement a linter that runs via git push
- [ ] Create a code style// implement a linter that runs via git push
- [ ] Create a test that runs before merging to main as a GH actions.
- [ ] Update the ReadMe to project standards.
- [ ] Update the ReadMe to project standards.



### Todos ~ Level 2
- [ ] Refactor the code in TypeScript
- [ ] Add a hover to the search (white highlight to the input).
- [ ] Add a hover to the search (white highlight to the input).
- [ ] Refactor the whole app in TypeScript


## Help/Suggestions
Create issues on the repo if errors are seen and they will be addressed them after todos are completed.

## Authors
[Me/@Nerajno](https://twitter.com/nerajno)
[Me/@Nerajno](https://twitter.com/nerajno)

## License
MIT License
Copyright (c) [2021] [Me/@Nerajno](https://twitter.com/nerajno)
Copyright (c) [2021] [Me/@Nerajno](https://twitter.com/nerajno)

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
Expand Down Expand Up @@ -89,10 +90,10 @@ Inspiration, code snippets, etc.
- New-er Sass methods (@use && @forward).
- Pathing structure ( relative or absolute).
- Environmental variables in Netlify => https://tinyurl.com/62pcv6ep
- Implementation of Sass in a react env and good reasonings why.
- Implementation of Sass in a react env and good reasonings why.
- Mixins and its modern implementation.
- Cypress and cypress studio

## Stuff that I still question
- Mixins
- Cypress functions ( cy.spy)
- Cypress functions (cy.spy)
23 changes: 23 additions & 0 deletions appmap.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
name: Burble
packages:
- path: build/static/css
- path: build/static/js
- path: src/components/button
- path: src/components/footer
- path: src/components/header
- path: src/components/hero_slide
- path: src/components/input
- path: src/components/modal
- path: src/components/movie-card
- path: src/components/movie-grid
- path: src/components/movie-list
- path: src/components/page-header
- path: src/components/pages/detail
- path: src/components/toggle
- path: cypress/component
- path: cypress/e2e
- path: cypress/plugins
- path: cypress/support
- path: src
language: javascript
appmap_dir: tmp/appmap
5 changes: 4 additions & 1 deletion cypress.config.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
const {defineConfig} = require("cypress");
// const webpackConfig = require('./config/webpack.config');


module.exports = defineConfig({
projectId: "y47h8y",
Expand All @@ -7,13 +9,14 @@ module.exports = defineConfig({
setupNodeEvents(on, config) {
return require("./cypress/plugins/index.js")(on, config);
},
baseUrl: "http://localhost:2000/",
baseUrl: "http://localhost:2000",
},

component: {
devServer: {
framework: "create-react-app",
bundler: "webpack",
// webpackConfig,
},
},
});
11 changes: 4 additions & 7 deletions cypress/e2e/searchandPlay.cy.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,11 @@ describe('', () => {
cy.get('[data-testid="input"]').type('The Shawshank Redemption');
cy.get('button').contains('Search').click();
cy.get('.movie-search > .small').click();
cy.get('a > h3').contains('The Shawshank Redemption').click({
force: true,
});
//cy.wait(2000);
cy.get('a > h3').contains('The Shawshank Redemption').click();
cy.contains('The Shawshank Redemption').should('be.visible');
cy.contains('Cast').should('be.visible');
cy.contains('Trailer').should('be.visible');
cy.get('.movie_player').should('be.visible');
// cy.contains('Cast').should('be.visible');
// cy.contains('Trailer').should('be.visible');
// cy.get('.movie_player').should('be.visible');
});
});

Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified cypress/videos/browseAndPlay.cy.js.mp4
Binary file not shown.
Binary file modified cypress/videos/darkMode.cy.js.mp4
Binary file not shown.
Binary file modified cypress/videos/navTest.cy.js.mp4
Binary file not shown.
Binary file modified cypress/videos/searchandPlay.cy.js.mp4
Binary file not shown.
Loading

0 comments on commit 1d546eb

Please sign in to comment.