Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [H5] tab组件安全区域避让适配 #16127

Open
wants to merge 3 commits into
base: 3.x
Choose a base branch
from

Conversation

kongxiaojun
Copy link
Contributor

@kongxiaojun kongxiaojun commented Jul 18, 2024

这个 PR 做了什么? (简要描述所做更改)

fix: [H5] tab组件安全区域避让适配

这个 PR 是什么类型? (至少选择一个)

  • 错误修复(Bugfix) issue: fix #
  • 新功能(Feature)
  • 代码重构(Refactor)
  • TypeScript 类型定义修改(Typings)
  • 文档修改(Docs)
  • 代码风格更新(Code style update)
  • 其他,请描述(Other, please describe):

这个 PR 涉及以下平台:

  • 所有小程序
  • 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 字节跳动小程序
  • QQ 轻应用
  • 京东小程序
  • 快应用平台(QuickApp)
  • Web 平台(H5)
  • 移动端(React-Native)
  • 鸿蒙(harmony)

Copy link

taro-bot2 bot commented Jul 18, 2024

欢迎提交 PR~ Taro 非常感谢您对开源事业做出的贡献!🌷🌷🌷

一般 PR 会在一到两周内进行 review,成功合入后会随下一个版本进行发布。

Review 需要耗费大量时间,所以请遵循以下规范,协助我们提高 review 效率🙏🙏🙏

  1. 详细介绍 PR 的背景(非常重要,例如解决了什么问题,该问题如何复现等)
  2. 确保 CI 顺利运行。
  3. 最好能提供对应的测试用例。

为了更好地进行沟通,请加入 Taro 开发者微信群:

This was referenced Aug 3, 2024
@@ -50,8 +51,7 @@ body {

&-bottom {
bottom: 0;
margin-bottom: constant(safe-area-inset-bottom);
margin-bottom: env(safe-area-inset-bottom);
margin-bottom: 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 是不是应该放前面

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.51%. Comparing base (936c61e) to head (4af1533).
Report is 1 commits behind head on 3.x.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              3.x   #16127   +/-   ##
=======================================
  Coverage   56.51%   56.51%           
=======================================
  Files         500      500           
  Lines       22768    22768           
  Branches     5639     5639           
=======================================
  Hits        12867    12867           
+ Misses       8679     8668   -11     
- Partials     1222     1233   +11     
Flag Coverage Δ
taro-cli 75.00% <ø> (ø)
taro-runner 54.00% <ø> (ø)
taro-runtime 79.39% <ø> (ø)
taro-web 49.22% <ø> (+8.74%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 6 files with indirect coverage changes

This was referenced Aug 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants