Skip to content

Commit

Permalink
ARROW-16176: [Release][C#] Use .NET 6.0 on Ubuntu 22.04
Browse files Browse the repository at this point in the history
Ubuntu 22.04 ships OpenSSL 3 and .NET 5.0 or earlier doesn't support
OpenSSL 3 yet.

Closes apache#12870 from kou/release-ubuntu-22.04-csharp

Lead-authored-by: Sutou Kouhei <[email protected]>
Co-authored-by: Krisztián Szűcs <[email protected]>
Co-authored-by: Eric Erhardt <[email protected]>
Signed-off-by: Krisztián Szűcs <[email protected]>
  • Loading branch information
3 people committed Apr 24, 2022
1 parent f6c99d5 commit f275f50
Show file tree
Hide file tree
Showing 15 changed files with 23 additions and 19 deletions.
2 changes: 1 addition & 1 deletion .env
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ UBUNTU=20.04
CLANG_TOOLS=12
CUDA=9.1
DASK=latest
DOTNET=3.1
DOTNET=6.0
GCC_VERSION=""
GO=1.16
HDFS=3.2.1
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/csharp.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ jobs:
strategy:
fail-fast: false
matrix:
dotnet: ['3.1.x']
dotnet: ['6.0.x']
steps:
- name: Install C#
uses: actions/setup-dotnet@v1
Expand Down Expand Up @@ -71,7 +71,7 @@ jobs:
strategy:
fail-fast: false
matrix:
dotnet: ['3.1.x']
dotnet: ['6.0.x']
steps:
- name: Install C#
uses: actions/setup-dotnet@v1
Expand All @@ -98,7 +98,7 @@ jobs:
strategy:
fail-fast: false
matrix:
dotnet: ['3.1.x']
dotnet: ['6.0.x']
steps:
- name: Install C#
uses: actions/setup-dotnet@v1
Expand Down
2 changes: 1 addition & 1 deletion ci/docker/conda-integration.dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ RUN wget -nv -O - https://dl.google.com/go/go${go}.linux-${arch}.tar.gz | tar -x

ENV DOTNET_ROOT=/opt/dotnet \
PATH=/opt/dotnet:$PATH
RUN curl -sSL https://dot.net/v1/dotnet-install.sh | bash /dev/stdin -Channel 3.1 -InstallDir /opt/dotnet
RUN curl -sSL https://dot.net/v1/dotnet-install.sh | bash /dev/stdin -Channel 6.0 -InstallDir /opt/dotnet

ENV ARROW_BUILD_INTEGRATION=ON \
ARROW_BUILD_STATIC=OFF \
Expand Down
2 changes: 1 addition & 1 deletion ci/docker/ubuntu-18.04-csharp.dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
# under the License.

ARG platform=bionic
ARG dotnet=3.1
ARG dotnet=6.0
FROM mcr.microsoft.com/dotnet/core/sdk:${dotnet}-${platform}

RUN dotnet tool install --tool-path /usr/local/bin sourcelink
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>netcoreapp2.1</TargetFramework>
<TargetFramework>net6.0</TargetFramework>
</PropertyGroup>

<ItemGroup>
Expand Down
8 changes: 4 additions & 4 deletions csharp/src/Apache.Arrow/Apache.Arrow.csproj
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>netstandard1.3;netcoreapp2.1</TargetFrameworks>
<TargetFrameworks>netstandard1.3;netcoreapp3.1</TargetFrameworks>
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
<DefineConstants>$(DefineConstants);UNSAFE_BYTEBUFFER;BYTEBUFFER_NO_BOUNDS_CHECK;ENABLE_SPAN_T</DefineConstants>

Expand Down Expand Up @@ -32,10 +32,10 @@
</EmbeddedResource>
</ItemGroup>

<ItemGroup Condition="'$(TargetFramework)' == 'netstandard1.3'">
<Compile Remove="Extensions\StreamExtensions.netcoreapp2.1.cs" />
<ItemGroup Condition="'$(TargetFrameworkIdentifier)' == '.NETStandard'">
<Compile Remove="Extensions\StreamExtensions.netcoreapp.cs" />
</ItemGroup>
<ItemGroup Condition="'$(TargetFramework)' == 'netcoreapp2.1'">
<ItemGroup Condition="'$(TargetFrameworkIdentifier)' == '.NETCoreApp'">
<Compile Remove="Extensions\StreamExtensions.netstandard.cs" />
<Compile Remove="Extensions\TupleExtensions.netstandard.cs" />
</ItemGroup>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>netcoreapp3.1</TargetFramework>
<TargetFramework>net6.0</TargetFramework>
</PropertyGroup>

<ItemGroup>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk.Web">

<PropertyGroup>
<TargetFramework>netcoreapp3.1</TargetFramework>
<TargetFramework>net6.0</TargetFramework>
</PropertyGroup>

<ItemGroup>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>netcoreapp3.1</TargetFramework>
<TargetFramework>net6.0</TargetFramework>

<IsPackable>false</IsPackable>
</PropertyGroup>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>netcoreapp3.1</TargetFramework>
<TargetFramework>net6.0</TargetFramework>
</PropertyGroup>

<ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion csharp/test/Apache.Arrow.Tests/Apache.Arrow.Tests.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>netcoreapp3.1</TargetFramework>
<TargetFramework>net6.0</TargetFramework>
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
</PropertyGroup>

Expand Down
2 changes: 1 addition & 1 deletion dev/archery/archery/integration/tester_csharp.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
_EXE_PATH = os.path.join(
ARROW_ROOT_DEFAULT,
"csharp/artifacts/Apache.Arrow.IntegrationTest",
"Debug/netcoreapp3.1/Apache.Arrow.IntegrationTest",
"Debug/net6.0/Apache.Arrow.IntegrationTest",
)


Expand Down
4 changes: 2 additions & 2 deletions dev/release/verify-release-candidate.sh
Original file line number Diff line number Diff line change
Expand Up @@ -342,7 +342,7 @@ install_csharp() {
show_info "Found C# at $(which csharp) (.NET $(dotnet --version))"
else
local csharp_bin=${ARROW_TMPDIR}/csharp/bin
local dotnet_version=3.1.405
local dotnet_version=6.0.202
local dotnet_platform=
case "$(uname)" in
Linux)
Expand Down Expand Up @@ -795,7 +795,7 @@ test_csharp() {
fi

sourcelink test artifacts/Apache.Arrow/Release/netstandard1.3/Apache.Arrow.pdb
sourcelink test artifacts/Apache.Arrow/Release/netcoreapp2.1/Apache.Arrow.pdb
sourcelink test artifacts/Apache.Arrow/Release/netcoreapp3.1/Apache.Arrow.pdb

popd
}
Expand Down
4 changes: 4 additions & 0 deletions dev/tasks/verify-rc/github.macos.amd64.yml
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,10 @@ jobs:
distribution: 'temurin'
java-version: '11'

- uses: actions/setup-dotnet@v2
with:
dotnet-version: '6.0.x'

- uses: actions/setup-node@v2-beta
with:
node-version: '16'
Expand Down

0 comments on commit f275f50

Please sign in to comment.