Skip to content

add 2014_1 wsdl, make search results work when there is only a single result on a page #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

add 2014_1 wsdl, make search results work when there is only a single result on a page #82

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
559b2c3
2014_1 wsdl
pospischil Jun 17, 2014
30eedc7
make search result more robust when there is a single item in the res…
pospischil Jun 17, 2014
d2843ee
add additional attributes to sales_order per the netsuite API
pospischil Jun 21, 2014
63565ea
protect against a null response
pospischil Jul 14, 2014
db66c86
safer null protection
pospischil Jul 14, 2014
90f9701
remove 2014_1 wsdl
pospischil Jul 22, 2014
b48a41f
Change savon version to 2.2.0.
dkoslow Jul 24, 2014
6f01428
Add support for between operator
pospischil Aug 14, 2014
1da9059
add a bunch of netsuite configuration options
pospischil Nov 10, 2014
cddb3a0
missing comma
pospischil Nov 10, 2014
de6b09b
default to peer
pospischil Nov 10, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/netsuite/support/search_result.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,15 +23,15 @@ def initialize(response, result_class)
if response.body.has_key?(:record_list)
# basic search results
record_list = response.body[:record_list][:record]
record_list = [record_list] if @total_records == 1
record_list = [record_list] unless record_list.is_a?(Array)
Copy link
Member

@iloveitaly iloveitaly Jun 19, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious... why was this needed? What situation broke the existing implementation?

Copy link
Contributor Author

@pospischil pospischil Jun 19, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you have more than one page of items and the last page has only a single item.

Copy link
Member

@iloveitaly iloveitaly Aug 26, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, got it. Nice catch! Merged this into master.


record_list.each do |record|
results << result_class.new(record)
end
elsif response.body.has_key? :search_row_list
# advanced search results
record_list = response.body[:search_row_list][:search_row]
record_list = [record_list] if @total_records == 1
record_list = [record_list] unless record_list.is_a?(Array)

Copy link
Member

@iloveitaly iloveitaly Aug 26, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In what case this did this occur?

record_list.each do |record|
# TODO because of customFieldList we need to either make this recursive
Expand Down
Loading