Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bessctl: add init/cmd argument introspection #1012

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

melvinw
Copy link
Contributor

@melvinw melvinw commented Aug 13, 2020

This has been useful for a project I've been working on. Might be worth including a version upstream.

This change is backwards compatible with modules that elect to keep exposing their argument/init types as strings

@melvinw melvinw requested a review from sangjinhan August 13, 2020 00:18
@codecov
Copy link

codecov bot commented Aug 13, 2020

Codecov Report

Merging #1012 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1012   +/-   ##
=======================================
  Coverage   55.96%   55.96%           
=======================================
  Files           9        9           
  Lines        1165     1165           
=======================================
  Hits          652      652           
  Misses        513      513           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5250185...af1b6fd. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant