Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates menu #22

Merged
merged 8 commits into from
Dec 11, 2024
Merged

Updates menu #22

merged 8 commits into from
Dec 11, 2024

Conversation

dragoss-nc
Copy link
Collaborator

@dragoss-nc dragoss-nc linked an issue Dec 10, 2024 that may be closed by this pull request
Menu #7
Closed
@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Dec 10, 2024 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Dec 10, 2024 •
edited
Loading

Page Scores Audits Google
📱 /andreas-demo/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /andreas-demo/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync aem-code-sync bot temporarily deployed to 7-menu December 10, 2024 12:21 Inactive
kesiah
kesiah requested changes Dec 10, 2024
View reviewed changes
blocks/header/header.css Outdated Show resolved Hide resolved
blocks/header/header.css Show resolved Hide resolved
blocks/header/header.js Show resolved Hide resolved
blocks/header/header.css Show resolved Hide resolved
@dragoss-nc dragoss-nc requested a review from kesiah December 10, 2024 16:14
kesiah
kesiah approved these changes Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@kesiah kesiah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick topic, the tool buttons in mobile don't have a hover state

@dragoss-nc dragoss-nc merged commit 9e58a86 into main Dec 11, 2024
2 checks passed
@dragoss-nc dragoss-nc mentioned this pull request Dec 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VadimMikh VadimMikh VadimMikh approved these changes

@kesiah kesiah kesiah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Menu
3 participants
@dragoss-nc @kesiah @VadimMikh