fix deprecated colour.XYZ_to_RGB #91
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
existing colour.XYZ_to_RGB has been deprecated and need to be updated. old version (before 0.4.3) Parameters: - XYZ (ArrayLike) – CIE XYZ tristimulus values. - illuminant_XYZ (ArrayLike) – CIE xy chromaticity coordinates or CIE xyY colourspace array of the illuminant for the input CIE XYZ tristimulus values. - illuminant_RGB (ArrayLike) – CIE xy chromaticity coordinates or CIE xyY colourspace array of the illuminant for the output RGB colourspace array. - matrix_XYZ_to_RGB (ArrayLike) – Matrix converting the CIE XYZ tristimulus values to RGB colourspace array, i.e. the inverse Normalised Primary Matrix (NPM). - chromatic_adaptation_transform (Literal['Bianco 2010', 'Bianco PC 2010', 'Bradford', 'CAT02 Brill 2008', 'CAT02', 'CAT16', 'CMCCAT2000', 'CMCCAT97', 'Fairchild', 'Sharp', 'Von Kries', 'XYZ Scaling'] | str | None) – Chromatic adaptation transform, if None no chromatic adaptation is performed. - cctf_encoding (Callable | None) – Encoding colour component transfer function (Encoding CCTF) or opto-electronic transfer function (OETF). new version (from 0.4.3) - XYZ (ArrayLike) – CIE XYZ tristimulus values. - colourspace (RGB_Colourspace | LiteralRGBColourspace | str) – Output RGB colourspace. - illuminant (ArrayLike | None) – CIE xy chromaticity coordinates or CIE xyY colourspace array of the illuminant for the input CIE XYZ tristimulus values. - chromatic_adaptation_transform (LiteralChromaticAdaptationTransform | str | None) – Chromatic adaptation transform, if None no chromatic adaptation is performed. - apply_cctf_encoding (bool) – Apply the RGB colourspace encoding colour component transfer function / opto-electronic transfer function. - args (Any) – Arguments for deprecation management. - kwargs (Any) – Keywords arguments for deprecation management.
davisadam10
approved these changes
Sep 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix deprecated colour.XYZ_to_RGB
Summary
Existing
colour.XYZ_to_RGBhas been deprecated and need to be updated.old version (before 0.4.3)
Parameters:
XYZ(ArrayLike) – CIE XYZ tristimulus values.illuminant_XYZ(ArrayLike) – CIE xy chromaticity coordinates or CIE xyY colourspace array of the illuminant for the input CIE XYZ tristimulus values.illuminant_RGB(ArrayLike) – CIE xy chromaticity coordinates or CIE xyY colourspace array of the illuminant for the output RGB colourspace array.matrix_XYZ_to_RGB(ArrayLike) – Matrix converting the CIE XYZ tristimulus values to RGB colourspace array, i.e. the inverse Normalised Primary Matrix (NPM).chromatic_adaptation_transform(Literal['Bianco 2010', 'Bianco PC 2010', 'Bradford', 'CAT02 Brill 2008', 'CAT02', 'CAT16', 'CMCCAT2000', 'CMCCAT97', 'Fairchild', 'Sharp', 'Von Kries', 'XYZ Scaling'] | str | None) – Chromatic adaptation transform, if None no chromatic adaptation is performed.cctf_encoding(Callable | None) – Encoding colour component transfer function (Encoding CCTF) or opto-electronic transfer function (OETF).new version (from 0.4.3)
Parameters:
XYZ(ArrayLike) – CIE XYZ tristimulus values.colourspace(RGB_Colourspace | LiteralRGBColourspace | str) – Output RGB colourspace.illuminant(ArrayLike | None) – CIE xy chromaticity coordinates or CIE xyY colourspace array of the illuminant for the input CIE XYZ tristimulus values.chromatic_adaptation_transform(LiteralChromaticAdaptationTransform | str | None) – Chromatic adaptation transform, if None no chromatic adaptation is performed.apply_cctf_encoding(bool) – Apply the RGB colourspace encoding colour component transfer function / opto-electronic transfer function.args(Any) – Arguments for deprecation management.kwargs(Any) – Keywords arguments for deprecation management.