Rename serverWebExchangeContextFilter to dgsServerWebExchangeContextFilter #2063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ilter. This is a workaround for compatibility with Spring Hateoas.
paulbakker
requested review from
kilink,
srinivasankavitha,
iuliiasobolevska,
kzwang,
asibross,
iparadiso and
jjacobs44
as code owners
iparadiso
approved these changes
Nov 15, 2024
iuliiasobolevska
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a workaround for compatibility with Spring Hateoas.
Spring Hateoas doesn't do proper autoconfiguration, instead they have a custom mechanism for this. Unfortunately this mechanism doesn't play nice with bean conditionals, leading to a duplicate bean exception on
serverWebExchangeContextFilter, even though this bean is@ConditionalOnMissingBeanin DGS.While this isn't directly a problem for DGS, there are many projects that use Spring Hateoas, often as a transitive through spring-data-rest. Because this is a simple workaround it's probably worth just renaming the bean in DGS.