Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metric for last announced version in producer #459

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions gradle.properties
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
org.gradle.parallel=true
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@
import java.util.concurrent.atomic.AtomicInteger;

public class HollowProducerMetrics extends HollowMetrics {
private long lastAnnouncedVersion = 0;

private int cyclesCompleted = 0;
private int cyclesSucceeded = 0;
private int cycleFailed = 0;
Expand Down Expand Up @@ -65,7 +67,7 @@ public void updateCycleMetrics(Status status, HollowProducer.ReadState readState

if(readState != null) {
HollowReadStateEngine hollowReadStateEngine = readState.getStateEngine();
super.update(hollowReadStateEngine, version);
update(hollowReadStateEngine, version);
} else {
super.update(version);
}
Expand Down Expand Up @@ -138,4 +140,13 @@ public int getReverseDeltasCompleted() {
public int getReverseDeltasFailed() {
return reverseDeltasFailed;
}

public long getLastAnnouncedVersion() {
return lastAnnouncedVersion;
}

protected void update(HollowReadStateEngine hollowReadStateEngine, long version) {
lastAnnouncedVersion = version;
super.update(hollowReadStateEngine, version);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -37,19 +37,39 @@ public void metricsDoNotBreakWithNullStateEngineInFail() {
Assert.assertEquals(hollowProducerMetrics.getCycleFailed(), 1);
}

@Test
public void metricsWhenNothingToPublish() {
HollowProducer producer = HollowProducer.withPublisher(blobStore)
.withBlobStager(new HollowInMemoryBlobStager())
.build();

producer.runCycle(new HollowProducer.Populator() {
public void populate(HollowProducer.WriteState state) throws Exception {
}
});

HollowProducerMetrics hollowProducerMetrics = producer.getMetrics();
Assert.assertEquals(hollowProducerMetrics.getLastAnnouncedVersion(), 0);
Assert.assertEquals(hollowProducerMetrics.getCyclesSucceeded(), 1);
Assert.assertEquals(hollowProducerMetrics.getCyclesCompleted(), 1);
Assert.assertEquals(hollowProducerMetrics.getTotalPopulatedOrdinals(), 0);
Assert.assertEquals(hollowProducerMetrics.getSnapshotsCompleted(), 0);
}

@Test
public void metricsWhenPublishingSnapshot() {
HollowProducer producer = HollowProducer.withPublisher(blobStore)
.withBlobStager(new HollowInMemoryBlobStager())
.build();

producer.runCycle(new HollowProducer.Populator() {
long version = producer.runCycle(new HollowProducer.Populator() {
public void populate(HollowProducer.WriteState state) throws Exception {
state.add(Integer.valueOf(1));
}
});

HollowProducerMetrics hollowProducerMetrics = producer.getMetrics();
Assert.assertEquals(hollowProducerMetrics.getLastAnnouncedVersion(), version);
Assert.assertEquals(hollowProducerMetrics.getCyclesSucceeded(), 1);
Assert.assertEquals(hollowProducerMetrics.getCyclesCompleted(), 1);
Assert.assertEquals(hollowProducerMetrics.getTotalPopulatedOrdinals(), 1);
Expand Down