Properly handle nargs=-1 for Click API #2219
Conversation
| @@ -319,7 +333,7 @@ def getattr_wrapper(_self, name): | |||
| defaults, | |||
| ) = extract_all_params(cli_collection) | |||
|
|
|||
| def _method(_self, **kwargs): | |||
| def _method(_self, *args, **kwargs): | |||
There was a problem hiding this comment.
do we need to use the *args introduced here somewhere?
This is because we do use **kwargs inside _method_sanity_check later..
There was a problem hiding this comment.
Ya, without it it didn't work for functions that have args. I think the signature changes or something.
| @@ -379,6 +393,9 @@ def execute(self) -> List[str]: | |||
| else: | |||
| components.append("--%s" % k) | |||
| components.append(str(i)) | |||
| elif v is None: | |||
| continue # Skip None values -- they are defaults and converting | |||
| # them to string will not be what the user wants | |||
There was a problem hiding this comment.
any quick example for cases where we get None?
There was a problem hiding this comment.
also, what about checking for v is None when looping over args.items()
this check is only for looping over options.items()
do we need it? just in case..
There was a problem hiding this comment.
we could but I don't think we would hit it. This case happens basically when a default value of None was passed on the command line. It transformed into a None string.
No description provided.