Skip to content

Commit

Permalink
Lowering Parameter B error threshold to 21 (the highest limit in ST 2…
Browse files Browse the repository at this point in the history
…067-21)
  • Loading branch information
fschleich committed Aug 20, 2024
1 parent 5d7d756 commit 26233df
Showing 1 changed file with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -519,23 +519,23 @@ private static boolean validateHT(CompositionImageEssenceDescriptorModel imageDe

/*
* NOTE: The Parameter B constraints in ST 2067-21:2023 are arguably too narrow, and existing implementations do violate them under certain circumstances.
* Since practical issues are not expected from software decoders for Parameter B values <= 24, we only raise WARNING for spec violations below that threshold.
* Since practical issues are not expected from software decoders otherwise, an ERROR is currently returned only for values that exceed the max value (21)
* allowed for any configuration by ST 2067-21:2023. A WARNING is provided for values that exceed the limit stated in ST 2067-21:2023, but not 21.
*
* TODO: This should be revisited as more implementations become available. Discussion for reference: https://github.com/SMPTE/st2067-21/issues/7
*/

if (codestreamB > 24) {
if (codestreamB > 21) {
logger.addError(
IMFErrorLogger.IMFErrors.ErrorCodes.APPLICATION_COMPOSITION_ERROR,
IMFErrorLogger.IMFErrors.ErrorLevels.NON_FATAL,
"APP2.HT: Parameter B has exceeded its limit to an extend that decoder issues are to be expected");
"APP2.HT: Parameter B has exceeded its limit to an extent that decoder issues are to be expected");
isValid = false;
} else if (codestreamB > maxB) {
logger.addError(
IMFErrorLogger.IMFErrors.ErrorCodes.APPLICATION_COMPOSITION_ERROR,
IMFErrorLogger.IMFErrors.ErrorLevels.WARNING,
"APP2.HT: Parameter B has exceeded its limits");
isValid = true;
}

return isValid;
Expand Down

0 comments on commit 26233df

Please sign in to comment.