Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for MGA S-ADM Virtual Tracks (SMPTE ST 2067-203) #376

Merged
merged 40 commits into from
Sep 10, 2024
Merged

Add support for MGA S-ADM Virtual Tracks (SMPTE ST 2067-203) #376

merged 40 commits into from
Sep 10, 2024

Conversation

wruppelx
Copy link
Contributor

Extensions and test cases for 2067-203 virtual tracks.

IMFTool added 23 commits November 1, 2023 17:02
@IMFTool
MGA S-ADM Virtual track alpha V0
888040f
@IMFTool
Check for each MGA S-ADM Virtual Track if MGASADMVirtualTrackParamete…
fbdaea4 
…rSet is present
@IMFTool
Extended MGASADMVirtualTrackParameterSet checks
9d95418
@IMFTool
Extended MGASADMVirtualTrackParameterSet checks
c6448e7
@IMFTool
ADM Audio Virtual track alpha V0
855d5d7
@IMFTool
Additional 2067-204 tests
b9f1e59
@IMFTool
Merge pull request #12 from wruppelx/feature/ADMAudioSequence
2e203b4 
Feature/adm audio sequence
@IMFTool
Additional 2067-204 tests
14f4857
@IMFTool
Merge pull request #13 from wruppelx/feature/ADMAudioSequence
9b800d4 
Additional 2067-204 tests
@IMFTool
Merge pull request #14 from wruppelx/feature/MGASADMSignalSequence
a11392e 
Adds 2067-203 and 2067-204 checks to master branch
@IMFTool
Additional -203/-204 checks
538d729
@IMFTool
Additional VirtualTrackParameterSet checks for -203 and -204
aebcbe0
@IMFTool
Fix in ADMChannelMapping
fe857e0
@IMFTool
Additional ST 2067-203 tests
c67578f
@IMFTool
Additional ST 2067-204 tests
d5500ee
@IMFTool
2067-201,-203 and -204 tests added to IMFTrackFileReader
0e383b7
@IMFTool
2067-203 and -204 refinements
b79c3c0
@IMFTool
Debug messages removed
caba558
@IMFTool
Unit tests for 2067-203 nd 2067-204 added
4381bf6
@IMFTool
Merged with upstream
f03164d
@IMFTool
ST 2067-203 MGA S-ADM Virtual Track support for Photon
35c84bd
@IMFTool
ST 2067-203 MGA S-ADM Virtual Track support for Photon rev1
cf13719
@IMFTool
ST 2067-203 MGA S-ADM Virtual Track support for Photon rev2
3f02ebb
@fschleich
Cleaned up UL constants
c8616a1 
- deleted duplicate UL constant MGAAudioEssenceUncompressedSoundCoding
- deleted unused UL constant IMF_MGASADM_ESSENCE_CLIP_WRAPPED_ELEMENT_UL
- aligned naming of remaining constants with SMPTE metadata register
danielhdz13-netflix
danielhdz13-netflix reviewed Aug 23, 2024
View reviewed changes
src/main/java/com/netflix/imflibrary/st2067_2/ApplicationCompositionFactory.java Outdated
@@ -117,6 +120,9 @@ public static ApplicationComposition getApplicationComposition(ResourceByteRange
Constructor<?> constructor = clazz.getConstructor(IMFCompositionPlaylistType.class, Set.class);
composition = (ApplicationComposition) constructor.newInstance(imfCompositionPlaylistType, homogeneitySelectionSet);
imfErrorLogger.addAllErrors(composition.getErrors());
// ST 2067-203 MGASADMVirtualTrackParameterSet checks
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could there be a better place to invoke this IMFMGASADMConstraintsChecker.checkMGASADMVirtualTrackParameterSet() method? Maybe in the inheritors of the ApplicationComposition class?

Since this is a factory class that doesn't invoke any other constraints checks, there may be a better, more targeted place to perform these validations.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to src/main/java/com/netflix/imflibrary/app/IMPAnalyzer.java

danielhdz13-netflix
danielhdz13-netflix reviewed Aug 23, 2024
View reviewed changes
src/test/java/com/netflix/imflibrary/st2067_203/IMPAnalyzerTest.java Outdated
@@ -0,0 +1,452 @@
/*
*
* Copyright 2024 RheinMain University of Applied Sciences, Wiesbaden, Germany.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed.

IMFTool and others added 3 commits August 26, 2024 10:22
@IMFTool
Additional MGA S-ADM CPL test cases
e0399f6
@IMFTool
ST 2067-203 MGA S-ADM Virtual Track support for Photon rev3
9360d3a
@fschleich
Maintaining signatures of public methods
0774648 
- reverting updates to previously deprecated method
- maintaining (but deprecated) existing constructor without support for extension properties
wruppelx and others added 8 commits August 29, 2024 10:19
@wruppelx @fschleich
Update src/main/java/com/netflix/imflibrary/st2067_203/IMFMGASADMCons…
4c2edf8 
…traintsChecker.java

Co-authored-by: Florian Schleich <[email protected]>
@wruppelx @fschleich
Update src/main/java/com/netflix/imflibrary/st2067_203/MGAAudioMetada…
c95ee26 
…taSubDescriptor.java

Co-authored-by: Florian Schleich <[email protected]>
@wruppelx @fschleich
Update src/main/java/com/netflix/imflibrary/st2067_203/IMFMGASADMCons…
702acd0 
…traintsChecker.java

Co-authored-by: Florian Schleich <[email protected]>
@wruppelx @fschleich
Update src/main/java/com/netflix/imflibrary/st2067_203/IMFMGASADMCons…
69bfa44 
…traintsChecker.java

Co-authored-by: Florian Schleich <[email protected]>
@wruppelx @fschleich
Update src/main/java/com/netflix/imflibrary/st2067_203/MGASADMTrackFi…
7f9bee4 
…leConstraints.java

Co-authored-by: Florian Schleich <[email protected]>
@wruppelx @fschleich
Update src/main/java/com/netflix/imflibrary/st2067_203/MGASADMTrackFi…
5fdda14 
…leConstraints.java

Co-authored-by: Florian Schleich <[email protected]>
@IMFTool
ST references updated
4161fb0
@IMFTool
ST 2067-203 MGA S-ADM Virtual Track support for Photon rev4
56dd13d
@fschleich fschleich merged commit e3fd12f into Netflix:master Sep 10, 2024
1 check passed
@wruppelx wruppelx deleted the feature-wruppelx/S-ADM branch September 10, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielhdz13-netflix danielhdz13-netflix danielhdz13-netflix left review comments

@fschleich fschleich fschleich approved these changes

@davidt-netflix davidt-netflix Awaiting requested review from davidt-netflix

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wruppelx @fschleich @danielhdz13-netflix @IMFTool