Skip to content

[Bugfix] Missing VideoLineMap element shall be reported for all applications #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fschleich merged 1 commit into from
Nov 19, 2024
Merged

[Bugfix] Missing VideoLineMap element shall be reported for all applications #391

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/main/java/com/netflix/imflibrary/st2067_2/CompositionImageEssenceDescriptorModel.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,6 @@ public CompositionImageEssenceDescriptorModel(@Nonnull UUID imageEssencedescript
this.sampling = Sampling.Unknown;
parseApp5SubDescriptors();
parseApp5PixelLayout();
parseApp5VideoLineMap();
} else {
this.pixelBitDepth = null;
this.quantization = Quantization.Unknown;
Expand All @@ -196,7 +195,7 @@ public CompositionImageEssenceDescriptorModel(@Nonnull UUID imageEssencedescript

this.sampling = parseSampling(this.colorModel);
}

parseVideoLineMap();
this.j2kParameters = J2KHeaderParameters.fromDOMNode(imageEssencedescriptorDOMNode);
}
else {
Expand Down Expand Up @@ -707,7 +706,7 @@ private void parseApp5SubDescriptors() {
return;
}

private void parseApp5VideoLineMap() {
private void parseVideoLineMap() {
DOMNodeObjectModel videoLineMap = imageEssencedescriptorDOMNode.getDOMNode(regXMLLibDictionary.getSymbolNameFromURN(videoLineMapUL));
if (videoLineMap == null) {
imfErrorLogger.addError(IMFErrorLogger.IMFErrors.ErrorCodes.APPLICATION_COMPOSITION_ERROR,
Expand Down