Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better types #63

Open
wants to merge 37 commits into
base: main
Choose a base branch
from
Open

Better types #63

wants to merge 37 commits into from

Conversation

andreiburdusa
Copy link
Contributor

@andreiburdusa andreiburdusa commented Nov 14, 2024

After #62

  • replace abbrev UInt256 := Fin UInt256.size with
structure UInt256 where
  val : Fin UInt256.size
  • make gas cost a natural number to avoid overflow

Extra: add 0x0a to π; add check for blob base fee


Results:
Overall, not checking the balance and not having reconciled the expected errors yet, there are approximatively

  • 279 tests blacklisted
  • 21,788 tests running
  • 19,360 tests succeeding

19,360 / (21,788 + 279) = 87.7%

@andreiburdusa andreiburdusa force-pushed the andreiburdusa/better-types branch from 7343f85 to 104a61c Compare November 15, 2024 15:58
@andreiburdusa andreiburdusa marked this pull request as ready for review November 20, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants