Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update blockifier #2397

Open
wants to merge 38 commits into
base: main
Choose a base branch
from
Open

Update blockifier #2397

wants to merge 38 commits into from
+4,462 −1,604

Conversation

AnkushinDaniil
Copy link
Contributor

This pull request includes several changes to the vm module, primarily focusing on extending the class information in vm/class.go, updating dependencies in Cargo.toml.

Class Information Extension:

  • Updated the marshalClassInfo function in vm/class.go to include ClassVersion and SierraVersion fields for both Cairo0Class and CompiledClass. [1] [2]

Dependency Updates:

  • Updated dependencies in vm/rust/Cargo.toml to newer versions, including blockifier, cairo-lang-starknet-classes, cairo-lang-runner, starknet_api, and starknet-types-core.

@AnkushinDaniil AnkushinDaniil added VM dependencies Pull requests that update a dependency file go Pull requests that update Go code rust Pull requests that update Rust code labels Jan 24, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 24, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 77.40586% with 54 lines in your changes missing coverage. Please review.

Project coverage is 73.27%. Comparing base (668c093) to head (ef7f534).

Files with missing lines Patch % Lines
rpc/v7/trace.go 61.81% 17 Missing and 4 partials ⚠️
rpc/v8/trace.go 73.80% 9 Missing and 2 partials ⚠️
rpc/v7/simulation.go 41.66% 7 Missing ⚠️
rpc/v6/simulation.go 50.00% 4 Missing ⚠️
rpc/v6/trace.go 55.55% 4 Missing ⚠️
node/throttled_vm.go 50.00% 2 Missing and 1 partial ⚠️
rpc/v8/simulation.go 96.90% 2 Missing and 1 partial ⚠️
rpc/v6/handlers.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2397      +/-   ##
==========================================
+ Coverage   73.13%   73.27%   +0.14%     
==========================================
  Files         142      142              
  Lines       17095    17211     +116     
==========================================
+ Hits        12503    12612     +109     
- Misses       3718     3719       +1     
- Partials      874      880       +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AnkushinDaniil AnkushinDaniil requested a review from cicr99 January 24, 2025 19:23
@rianhughes rianhughes mentioned this pull request Jan 29, 2025
Open
rianhughes
rianhughes reviewed Jan 29, 2025
View reviewed changes
vm/rust/src/lib.rs Outdated Show resolved Hide resolved
rianhughes
rianhughes reviewed Jan 29, 2025
View reviewed changes
vm/rust/src/lib.rs Outdated Show resolved Hide resolved
rianhughes
rianhughes reviewed Jan 29, 2025
View reviewed changes
vm/rust/src/lib.rs Outdated Show resolved Hide resolved
rianhughes
rianhughes reviewed Jan 29, 2025
View reviewed changes
vm/rust/src/lib.rs Outdated Show resolved Hide resolved
rianhughes
rianhughes reviewed Jan 29, 2025
View reviewed changes
vm/rust/src/lib.rs Outdated Show resolved Hide resolved
rianhughes
rianhughes reviewed Jan 29, 2025
View reviewed changes
vm/rust/src/lib.rs Outdated Show resolved Hide resolved
rodrigo-pino
rodrigo-pino reviewed Jan 30, 2025
View reviewed changes
Copy link
Contributor

@rodrigo-pino rodrigo-pino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First round of review. Will do another pass later. Overall, everything looks good to me.

vm/rust/resources/versioned_constants_0_13_0.json Outdated Show resolved Hide resolved
vm/rust/resources/versioned_constants_0_13_2.json Outdated Show resolved Hide resolved
vm/rust/src/juno_state_reader.rs Outdated Show resolved Hide resolved
vm/rust/src/juno_state_reader.rs Show resolved Hide resolved
vm/rust/src/lib.rs Outdated Show resolved Hide resolved
vm/vm_bridge.h Outdated Show resolved Hide resolved
@AnkushinDaniil AnkushinDaniil force-pushed the daniil/update-blockifier-0.13.4 branch 3 times, most recently from bcbc529 to ee0a9a3 Compare January 31, 2025 12:40
@rianhughes
Copy link
Contributor

Up to the above comments the PR ltgm

rianhughes
rianhughes reviewed Feb 3, 2025
View reviewed changes
rpc/simulation.go Outdated Show resolved Hide resolved
rodrigo-pino
rodrigo-pino reviewed Feb 3, 2025
View reviewed changes
mocks/mock_vm.go Outdated Show resolved Hide resolved
rpc/simulation_pkg_test.go Outdated Show resolved Hide resolved
vm/vm_ffi.h Outdated Show resolved Hide resolved
vm/vm.go Outdated Show resolved Hide resolved
rpc/simulation_pkg_test.go Outdated Show resolved Hide resolved
@AnkushinDaniil AnkushinDaniil mentioned this pull request Feb 5, 2025
Closed
@AnkushinDaniil AnkushinDaniil force-pushed the daniil/update-blockifier-0.13.4 branch from 132a67b to 28c81ec Compare February 5, 2025 15:53
AnkushinDaniil and others added 24 commits February 7, 2025 17:07
@AnkushinDaniil
Rename from vm_bridge.h to vm_ffi.h
59d7868
@AnkushinDaniil
Add max
70c9f06
@AnkushinDaniil
Rename minimal_l1_gas_amount_vector to minimal_gas_vector
10f035a
@AnkushinDaniil
Rename from vm_bridge.h to vm_ffi.h
559ab06
@AnkushinDaniil
Add tests
d8ce5f8
@AnkushinDaniil
Add gas consumed
0a32207
@AnkushinDaniil
Add test
4bd8d72
@AnkushinDaniil
Make methods pure functions
36243bc
@AnkushinDaniil
Change comment
6d7881f
@AnkushinDaniil
Move httpHeader.Set after error handling
86262af
@AnkushinDaniil
Fix linter
2fd3e38
@AnkushinDaniil
Add ExecutionResults
fc818f6
@AnkushinDaniil
Fix test
322217b
@AnkushinDaniil
Rename from VM_BRIDGE_H to MV_FFI_H
2c79442
@AnkushinDaniil
Add sierra version
4238190
@AnkushinDaniil @rodrigo-pino
Initialize initial_gas directly
b25d2c3 
Co-authored-by: Rodrigo <[email protected]>
Signed-off-by: Daniil Ankushin <[email protected]>
@AnkushinDaniil
Remove commented code
b695b32
@AnkushinDaniil
Fix compile issue
cb33adb
@AnkushinDaniil
Update starknet_traceTransaction
01f6525
@AnkushinDaniil
Inline lowerStr
a4518a7
@AnkushinDaniil
Update createSimulatedTransactions
dd8f2d1
@AnkushinDaniil
Add TestCreateSimulatedTransactions
47b6a6f
@AnkushinDaniil
Add TestHandleExecutionError
51e7ba0
@AnkushinDaniil
Fix rebase issues
d9adf27
@AnkushinDaniil AnkushinDaniil force-pushed the daniil/update-blockifier-0.13.4 branch from c3c7be6 to d9adf27 Compare February 7, 2025 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rianhughes rianhughes rianhughes left review comments

@rodrigo-pino rodrigo-pino rodrigo-pino left review comments

@cicr99 cicr99 Awaiting requested review from cicr99

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code high priority rust Pull requests that update Rust code VM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AnkushinDaniil @rianhughes @rodrigo-pino