Add 0.6 rpc endpoints #2401
Closed
Add 0.6 rpc endpoints #2401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2401 +/- ##
==========================================
+ Coverage 74.41% 75.01% +0.60%
==========================================
Files 113 113
Lines 13016 13338 +322
==========================================
+ Hits 9686 10006 +320
+ Misses 2592 2585 -7
- Partials 738 747 +9 ☔ View full report in Codecov by Sentry. |
AnkushinDaniil
force-pushed
the
daniil/add-0.6-rpc-endpoints
branch
from
e21edc9 to
6219405
Compare
|
Blocked while we work on an alternative solution that will simplify rpc version managing for the future (#2413) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review and merge after #2407
This pull request partially reverts #2229
Changes to MockVM and ThrottledVM:
CallandExecutemethods inMockVMto accept an additional boolean parameteruseBlobData. (mocks/mock_vm.go) [1] [2]ThrottledVMto include theuseBlobDataparameter in itsCallandExecutemethods. (node/throttled_vm.go) [1] [2]Changes to RPC Handlers:
BlockWithTxHashesV0_6andBlockWithTxsV0_6to handle version 0.6 specific responses. (rpc/block.go) [1] [2]FeeEstimateV0_6and corresponding conversion functions to support fee estimation for version 0.6. (rpc/estimate_fee.go) [1] [2]EstimateFeeV0_6andEstimateMessageFeeV0_6methods to handle fee estimation for version 0.6. (rpc/estimate_fee.go) [1] [2]Additional Changes:
Newfunction innode/node.goto register methods for both version 0.6 and 0.7, and adjusted the metrics accordingly. (node/node.go) [1] [2]rpc/block_test.go,rpc/estimate_fee_test.go) [1] [2] [3]These changes ensure that the API can handle both version 0.6 and 0.7 requests, providing backward compatibility and supporting new features.