remove block_id from starknet_subscribeTransactionStatus #2410
+6
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2410 +/- ##
==========================================
- Coverage 74.56% 74.39% -0.18%
==========================================
Files 113 113
Lines 13020 13016 -4
==========================================
- Hits 9709 9683 -26
- Misses 2579 2597 +18
- Partials 732 736 +4 ☔ View full report in Codecov by Sentry. |
AnkushinDaniil
approved these changes
Jan 31, 2025
wojciechos
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
BlockIDparameter fromstarknet_subscribeTransactionStatusmethodspec: https://github.com/starkware-libs/starknet-specs/blob/v0.8.0-rc2/api/starknet_ws_api.json#L134