-
Notifications
You must be signed in to change notification settings - Fork 475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
eip 7840 implementation #7964
Merged
eip 7840 implementation #7964
Changes from 86 commits
Commits
Show all changes
105 commits
Select commit
Hold shift + click to select a range
c38a641
add MaxBlobCount, TargetBlobCount to chainSpec
yerke26 10342cc
Change FeeOracleHistory to use right MaxBlobCount
yerke26 5ef5d36
fix BlobGasUsedRatio
yerke26 6f45bc6
remove TargetBlobCount, MaxBlobCount constants
yerke26 0035b43
add PragueTransitionTimestamp
yerke26 d68374c
Merge branch 'master' into eip-7840
yerke26 b668cdf
remove PragueTransitionTimestamp, instead use Eip7002TransitionTimestamp
yerke26 eb77784
remove Eip4844MaxBlobCount, Eip4844TargetBlobCount from chainSpecParams
yerke26 b8bef08
fix TxValidatorTests
yerke26 7059480
fix TxValidatorTests
yerke26 b638d63
fix CancunStateTests
yerke26 0d5a076
fix TransactionProcessorEip4844Tests
yerke26 91f1b1f
fix TxPoolTests
yerke26 e494aa9
fix tests
yerke26 44481ba
fix FeeHistoryOracleTests
yerke26 05772a0
fix whitespaces
yerke26 b6b50b7
Merge branch 'master' into eip-7840
MarekM25 09a914d
remove hardcoded values
yerke26 1d271bd
Fix build errors
MarekM25 87acb12
Merge branch 'eip-7840' of https://github.com/nethermindeth/nethermin…
MarekM25 0aa4346
Fix OverridableReleaseSpec
MarekM25 87fc57d
remove hardcoded values
yerke26 f28e72a
add blobSchedule to chainSpec
yerke26 8804ccd
fix FeeHistoryOracleTests
yerke26 8c1c6f3
fix EthRpcModuleTests
yerke26 d9d60ab
fix PooledTxsRequestor
yerke26 6058cb1
use the release spec from the testcase and add prague count test
tanishqjasoria 78b9e33
rename
tanishqjasoria 22b7d1d
fix fee history oracle pre cancun
tanishqjasoria 4fbd890
fix gnosis and chiado specs
tanishqjasoria 6952229
Merge branch 'master' into eip-7840
tanishqjasoria 5b4c0d1
fix whitespaces
yerke26 cb445ee
Merge branch 'master' into eip-7840
MarekM25 e181b43
fix default blobCount and targetCount
MarekM25 43e1655
fix PooledTxsRequestor to use spec at current head
yerke26 0c309ea
fix PooledTxsRequestorTests
yerke26 c2737fc
CalculateMaxBlobTxSize through transitionActivations
yerke26 362f18c
set default TargetBlobCount, MaxBlobCount to zero
yerke26 2f1f6f2
fix defaults
MarekM25 43bda5a
set default value for gnosisChain
yerke26 1ecf556
add Eip7840DefaultBlobCountFraction for gnosis chain
yerke26 3872a10
fix gnosis, chiado chains json
yerke26 cc5c798
extended error message
MarekM25 58a3ff9
revert default value changes
yerke26 a528f1e
Merge branch 'master' into eip-7840
tanishqjasoria e8e760d
add blob price update franction
tanishqjasoria 28614f1
fix
tanishqjasoria 6886c52
another fix
tanishqjasoria 1286aea
set default values
tanishqjasoria 64dd8ab
fix an format
tanishqjasoria 38202ee
Merge branch 'master' into pectra-devnet-5
tanishqjasoria b95ac18
fix some tests
tanishqjasoria 0a4dbd2
Merge branch 'blob-price-fractiion' into pectra-devnet-5
tanishqjasoria f36e6c4
add blob price update fraction (#8053)
tanishqjasoria 78910ec
cosmetic
MarekM25 b288921
Merge branch 'eip-7840' of https://github.com/nethermindeth/nethermin…
MarekM25 340cafa
quick fix
tanishqjasoria 0d3712e
fix
MarekM25 d1283aa
remove _state
MarekM25 e7c94c1
ignore the hive test
MarekM25 52b679a
remove removed precompiles
tanishqjasoria c1879a6
fix mixed hex in foundation chainspec file
yerke26 4cd4a45
temporary fix for BlobSender
yerke26 812d7bd
add fork option to SendBlobs
yerke26 8f96e97
fix dependency problem
yerke26 62f5b68
revert
yerke26 2f2cc87
fix dependency error
yerke26 25a9832
revert bench_precompiles
yerke26 06b2117
Merge branch 'master' into eip-7840
yerke26 eeab3c1
fix dependency error
yerke26 6918f86
Merge branch 'master' into eip-7840
yerke26 efd377a
add mainnet, holesky, sepolia tests to
yerke26 389f8ca
refactoring
yerke26 f343cb1
ifx blobBaseFeeUpdateFraction in ChainSpecBasedSpecProvider
yerke26 428e98f
add blobBaseFeeUpdateFraction to holesky, sepolia chainspec files
yerke26 e96564a
resolved conflicts
MarekM25 76159e3
Merge branch 'eip-7840' of https://github.com/nethermindeth/nethermin…
MarekM25 ae96e22
fix compilation error
yerke26 255ec4f
fix ChainSpecBasedSpecProviderTests
yerke26 16e9e0d
refactoring of _configuredMaxBlobTxSize in PooledTxsRequestor
yerke26 fe89802
refactor MaxBlobGas, TargetBlobGas calculation (#8088)
yerke26 fe59bdf
fix _configuredMaxBlobTxSize
yerke26 9696cf1
Merge remote-tracking branch 'origin/eip-7840' into eip-7840
yerke26 1ad0ea8
fix SizeTxFilter
yerke26 d8c00fd
Small change in GetTransitionsMaxBlobGas
MarekM25 7cd8d85
naming fix
MarekM25 9ee577d
revert block exec context
tanishqjasoria 709e94f
revert explicit BlockExecutionContext
yerke26 bace0c3
remove explicit BlockExecutionContext
yerke26 64ed1dc
refactor BlobTxGasLimitExceeded TxErrorMessage
yerke26 5aa531c
refactor namings
yerke26 8441be2
refactoring, resolving comments
yerke26 f74738a
refactoring
yerke26 44d4ef3
refactor BlobTxGasLimitExceeded
yerke26 30a6bd7
move calculation of BlobGasFee to BlockExecutionContext from VM
yerke26 e3b52cd
Eip 7840 - add IReleaseSpec to BlockExecutionContext constructor (#8096)
yerke26 06157a4
Merge branch 'master' into eip-7840
yerke26 37b5079
resolve merge conflicts
yerke26 7d0ea7d
mark ChainSpecBasedSpecProviderTests sequential
yerke26 a25830c
add todo for ChainSpecBasedSpecProviderTests
yerke26 220c625
cosmetic
yerke26 cb64a5e
Merge branch 'master' into eip-7840
yerke26 0442a0f
resolve merge conflict
yerke26 3cf33a6
refactoring
yerke26 57ea6dd
refactor BlockErrorMessage
yerke26 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 changes: 0 additions & 20 deletions
20
src/Nethermind/Nethermind.Blockchain.Test/TestEip4844Config.cs
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should it be by fork name? Normally we are using timestamps now to mark changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, as per EIp it should be by fork name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't like it to be honest it is inconsistent with our previous chainspecs. EIP's shouldn't define internal stuff. Should we consider going to timestamps @MarekM25 ?