Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

admin_exportChain Implementation #8069

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

richardgreg
Copy link
Contributor

Fixes #7813

Changes

  • Declared admin_exportChain in Interface (iAdminRpcModule.cs) with the correct signature.
  • Implementation (AdminRpcModule.cs):
    • Added a new constructor parameter (IJsonSerializer).
    • Implemented admin_exportChain.
  • Adjusted the call in RegisterRpcModules.cs to new AdminRpcModule(...) so it provides the new IJsonSerializer parameter.
  • Created a function to invoke admin_exportChain from the command line.
  • Wrote a test ensuring the constructor call is valid, and the admin_exportChain method returns success and writes out the expected file.

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

Optional. Remove if not applicable.

Documentation

Requires documentation update

  • Yes
  • No

If yes, link the PR to the docs update or the issue with the details labeled docs. Remove if not applicable.

Requires explanation in Release Notes

  • Yes
  • No

If yes, fill in the details here. Remove if not applicable.

Remarks

Optional. Remove if not applicable.

@LukaszRozmej
Copy link
Member

We will be merging #6547 with admin_exportHistory and admin_importHistory soon, not sure if it makes sense to support this too. @asdacap @flcl42 @MarekM25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement admin_exportChain for admin rpc
2 participants