Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/move sync pivot to IBlockTree. #8203

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

asdacap
Copy link
Contributor

@asdacap asdacap commented Feb 13, 2025

  • Move sync pivot from ISyncConfig into IBlockTree and ancient block barriers so ISyncPointers.
    • Why into IBlockTree? Well, blocktree initialization need it so to prevent adding a new dependency to it, just put it in IBlockTree.
    • Plus if you think of it as FinalizedBlock, which it kinda is, it make a lot more sense.
  • Why ancient block barriers into ISyncPointers? Because IBlockTree is a bit fat, and the barriers are more of a sync concern, less important than sync pivot.
    • Combined portal and sharded block, direct era attached storage, the block barriers have a lot of logic.
    • And since ancient barriers rely on sync pivot for some reason, it kinda need to be put outside.

Types of changes

What types of changes does your code introduce?

  • Refactoring

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

  • Hive sync test passed

@asdacap asdacap requested a review from rubo as a code owner February 13, 2025 11:19
@asdacap asdacap marked this pull request as draft February 13, 2025 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant